Repository navigation
log: a group names its span - #230
Merged
Merged
Conversation
✅ Deploy Preview for detsys-ts-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reached
On-demand reviews are free for the next 11 days. After that, they cost $0.25 per reviewed file. Or wait 21 minutes for your next included review. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Your 34 included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Comment |
grahamc
force-pushed
the
otel-group-is-not-a-span
branch
from
September 9, 2026 13:05
5c09efe to
a53e5de
Compare
log.group used the group label as the span name. The labels are prose, thus Honeycomb held spans named `Installing Nix`, `Detecting systemd...` and `Directly spawning the daemon, since systemd is not available.`. A group still opens a span, because a group is a piece of work with a start and an end, which is what a span is. The name of that span is now an argument of its own. A span name names an operation: it stays short, and it stays the same from run to run, because Honeycomb groups by it. A label is prose that a person reads in the workflow log. One argument cannot be both. The function of a group now receives the span, so that the work inside can put attributes on it without a second call to open a span. It receives the span on an object, so that a later version can put more in it and no call site has to change.
grahamc
force-pushed
the
otel-group-is-not-a-span
branch
from
September 9, 2026 13:11
a53e5de to
7216721
Compare
gustavderdrache
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log.group used the group label as the span name.
The labels are prose, thus Honeycomb held spans named
Installing Nix,Detecting systemd...andDirectly spawning the daemon, since systemd is not available..A group still opens a span, because a group is a piece of work with a start and an end, which is what a span is.
The name of that span is now an argument of its own.
The function of a group now receives the span, so that the work inside can put attributes on it without a second call to open a span. It receives the span on an object, so that a later version can put more in it and no call site has to change.
Note this is a breaking API change for callers, but whatever.