Add a configurable partial approval emoji - #68
Open
jp-ayyappan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an optional emoji-partially-approved action input. When at least one approval exists but the configured approval threshold has not been reached, Slapr uses that reaction. Once the threshold is met, Slapr replaces it with the configured approved reaction. Changes requested continue to take precedence.
Motivation
Slapr already supports a configurable approval count, but it does not expose progress toward that count. This lets a workflow use ⏭️ while approvals are still pending and 🚢 when the threshold is met.
Describe how you validated your changes
Additional Notes
The new input is opt-in and has no default, so existing workflows retain their current behavior. Broader approval-policy configuration is intentionally left for focused follow-up changes.