Fix PR link matching after Slack mentions - #67
Open
chausler wants to merge 1 commit into
Open
Conversation
chausler
marked this pull request as ready for review
July 30, 2026 04:41
Author
|
@chouetz could you review this fix and approve the fork workflow run if needed? It fixes Slack review messages where a mention appears before the PR link; the full local test suite and Docker image validation pass. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A common Slack review request puts a user-group mention before the PR link:
The current greedy link expression captures from the mention opening bracket through the PR link closing bracket. Because that captured value no longer starts with the PR URL, Slapr logs
No message found requesting review, exits successfully, and never adds the status reaction.This means a natural mention-first review request silently loses its automation even though the workflow is green. Slapr should find the PR URL regardless of preceding Slack markup so a successful job reliably updates the message review state.
Summary
Validation
/private/tmp/slapr-venv/bin/python -m pytest(28 passed)docker build -t slapr:codex-link-match-test .docker run --rm --entrypoint python slapr:codex-link-match-test -c "import slapr"