feat(emojis): Distinguish approved reviews with inline comments - #58
Open
chouetz wants to merge 1 commit into
Open
feat(emojis): Distinguish approved reviews with inline comments#58chouetz wants to merge 1 commit into
chouetz wants to merge 1 commit into
Conversation
Use :approved_with_comments: emoji when an approval review contains inline code comments, and standard :approved: when it only has a general comment. This gives PR authors clearer signal that there are inline comments to address even though the review is an approval.
chouetz
marked this pull request as ready for review
March 18, 2026 17:41
Ishirui
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new emoji (
:approved_with_comments:) that is used when a review approval contains inline code comments, distinguishing it from a plain approval (:approved:) that has only a general comment or no comment at all.Motivation
When a reviewer approves a PR but leaves inline comments, the PR author should have a clear visual signal that there are code-level remarks to address. Using the standard
:approved:emoji doesn't convey this — the author might miss the inline feedback entirely.Describe how you validated your changes
approval-with-inline-comments) covering the new behaviorAdditional Notes
SLAPR_EMOJI_APPROVED_WITH_COMMENTSenvironment variable (defaults toapproved_with_comments)raw_data["pull_request_review_id"](PyGithub 1.45 doesn't expose this as a property)🤖 Generated with Claude Code