[CONTP-1787] Adds logs section to DDI config spec#3198
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoJun 26, 2026
Merged
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 522aa6e | Docs | Datadog PR Page | Give us feedback! |
Base automatically changed from
mathew.estafanous/checks-ddi-improvements
to
main
June 26, 2026 17:21
Mathew-Estafanous
force-pushed
the
mathew.estafanous/ddi-add-logs-section
branch
from
20a8070 to
b290757
Compare
Mathew-Estafanous
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b290757999
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tags: | ||
| - service:sample-app | ||
| - env:dev | ||
| logs: |
There was a problem hiding this comment.
This updates the standalone sample to the new top-level config.logs shape, but the distributed OLM CSV bundle/manifests/datadog-operator.clusterserviceversion.yaml still has the DatadogInstrumentation alm-example with logs nested under checks around lines 76-96. For clusters installing from the bundle, users copying the OperatorHub example will submit the old shape that the updated CRD no longer exposes, so the log configuration can be pruned/ignored instead of collected; please regenerate or update the CSV example alongside this sample.
Useful? React with 👍 / 👎.
levan-m
approved these changes
Jun 26, 2026
Mathew-Estafanous
force-pushed
the
mathew.estafanous/ddi-add-logs-section
branch
2 times, most recently
from
07f4e7c to
6d8506f
Compare
levan-m
approved these changes
Jun 26, 2026
Mathew-Estafanous
force-pushed
the
mathew.estafanous/ddi-add-logs-section
branch
from
6d8506f to
522aa6e
Compare
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
mathew.estafanous/ddi-add-logs-section
branch
levan-m
added a commit
that referenced
this pull request
Jun 27, 2026
* Add dd-octo-sts trust policy for release-dashboard-api on us1.ddbuild.io (#3197) Add dd-octo-sts trust policy for release-dashboard-api on us1.ddbuild.io Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: antonio.mejia <antonio.mejia@datadoghq.com> * fix(deps): vuln minor upgrades — 6 packages (minor: 2 · patch: 4) (#3148) * ADMS: vuln minor upgrades — 6 packages (minor: 2 · patch: 4) Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com> * chore: regenerate lockfiles after rebase Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com> * fix: update LICENSE-3rdparty.csv for moby/spdystream v0.5.1 sub-package The upgrade from github.com/moby/spdystream v0.5.0 to v0.5.1 introduced a new sub-package github.com/moby/spdystream/spdy with a BSD-3-Clause license. Add the missing entry to keep LICENSE-3rdparty.csv up to date. Environment: Datadog workspace Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com> Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com> * fix: sync api/go.mod with workspace after dependency upgrades Run 'go work sync' to keep api/go.mod consistent with the transitive dependency updates from the main module (golang.org/x/* version bumps pulled in by the moby/spdystream and opentelemetry upgrades). Environment: Datadog workspace Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com> Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com> * fix: add missing go.mod hash entries to api/go.sum 'go mod tidy' adds .mod file hash entries that 'go work sync' omits. Required to satisfy the check-golang-version CI validation. Environment: Datadog workspace Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com> Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com> --------- Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com> * ci(issue-triage): add reusable workflow from DataDog/issue-triage-action (#3187) * ci(issue-triage): add reusable workflow from DataDog/issue-triage-action Add issue triage workflow that delegates to the shared reusable action at DataDog/issue-triage-action v1.0.0. On each new issue the workflow runs Claude-based triage, applies a team label, and sends a Slack notification. * Use the good commit * [CONTP-1785] Replace container image with name in DDI check section (#3196) Add DatadogInstrumentation check containerName chore: update config sample Co-authored-by: mathew.estafanous <mathew.estafanous@datadoghq.com> * Update Operator Release Workflows (#3060) * sync operator release workflow * simplify diff detection * Add DatadogInstrumentation logs config (#3198) Add DatadogInstrumentation logs config Co-authored-by: mathew.estafanous <mathew.estafanous@datadoghq.com> --------- Co-authored-by: Antonio Mejia <antonio.mejia@datadoghq.com> Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com> Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com> Co-authored-by: Nicolas Schweitzer <nicolas.schweitzer@datadoghq.com> Co-authored-by: Mathew Estafanous <56979977+Mathew-Estafanous@users.noreply.github.com> Co-authored-by: mathew.estafanous <mathew.estafanous@datadoghq.com> Co-authored-by: Gabriel Dos Santos <91925154+gabedos@users.noreply.github.com> Co-authored-by: Claude <claude@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the DDI's
config.checks[*].logssection with a separateconfig.logs[*]section.Motivation
While checks and logs are often configured together, having logs under the checks section implies log collection needs an integration. This is not the case - so a separate section is a clearer user experience.
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel