Skip to content

[CONTP-1785] Replace container image with name in DDI check section#3196

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
mathew.estafanous/checks-ddi-improvements
Jun 26, 2026
Merged

[CONTP-1785] Replace container image with name in DDI check section#3196
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
mathew.estafanous/checks-ddi-improvements

Conversation

@Mathew-Estafanous

@Mathew-Estafanous Mathew-Estafanous commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Replaces spec.config.checks[*].containerImage with spec.config.checks[*].containerName

Motivation

When defining an autodiscovery check using the DDI CRD, it's more intuitive to match by a pod's container name instead of image ID.

Additional Notes

This is technically a breaking change so any agent version <=7.81 will fail to resolve the DDI CRD. However since this CRD is still in early preview we're going ahead with making the breaking change.

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: v7.82.x
  • Cluster Agent: v7.82.x

Describe your test plan

  • CI passes

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@datadog-official

datadog-official Bot commented Jun 25, 2026

Copy link
Copy Markdown

Code Coverage

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 44.90% (-0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ec2f417 | Docs | Datadog PR Page | Give us feedback!

@Mathew-Estafanous Mathew-Estafanous changed the title Add container-scoped logs to DatadogInstrumentation config Add container-scoped logs to DDI config and introduce container name to check Jun 25, 2026
@Mathew-Estafanous Mathew-Estafanous force-pushed the mathew.estafanous/checks-ddi-improvements branch 2 times, most recently from 6803e4e to 622cc1e Compare June 25, 2026 19:32
@Mathew-Estafanous Mathew-Estafanous changed the title Add container-scoped logs to DDI config and introduce container name to check Replace container image with name in DDI check section Jun 26, 2026
@Mathew-Estafanous Mathew-Estafanous force-pushed the mathew.estafanous/checks-ddi-improvements branch from 622cc1e to 3481300 Compare June 26, 2026 14:34
@Mathew-Estafanous Mathew-Estafanous self-assigned this Jun 26, 2026
@Mathew-Estafanous Mathew-Estafanous added this to the v1.29.0 milestone Jun 26, 2026
@Mathew-Estafanous Mathew-Estafanous changed the title Replace container image with name in DDI check section [CONTP-1785] Replace container image with name in DDI check section Jun 26, 2026
@Mathew-Estafanous Mathew-Estafanous marked this pull request as ready for review June 26, 2026 15:28
@Mathew-Estafanous Mathew-Estafanous requested a review from a team June 26, 2026 15:28
@Mathew-Estafanous Mathew-Estafanous requested a review from a team as a code owner June 26, 2026 15:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3481300263

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bundle/manifests/datadoghq.com_datadoginstrumentations.yaml
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the mathew.estafanous/checks-ddi-improvements branch June 26, 2026 17:21
levan-m added a commit that referenced this pull request Jun 27, 2026
* Add dd-octo-sts trust policy for release-dashboard-api on us1.ddbuild.io (#3197)

Add dd-octo-sts trust policy for release-dashboard-api on us1.ddbuild.io

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-authored-by: antonio.mejia <antonio.mejia@datadoghq.com>

* fix(deps): vuln minor upgrades — 6 packages (minor: 2 · patch: 4)  (#3148)

* ADMS: vuln minor upgrades — 6 packages (minor: 2 · patch: 4)

Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com>

* chore: regenerate lockfiles after rebase

Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com>

* fix: update LICENSE-3rdparty.csv for moby/spdystream v0.5.1 sub-package

The upgrade from github.com/moby/spdystream v0.5.0 to v0.5.1 introduced
a new sub-package github.com/moby/spdystream/spdy with a BSD-3-Clause
license. Add the missing entry to keep LICENSE-3rdparty.csv up to date.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com>

* fix: sync api/go.mod with workspace after dependency upgrades

Run 'go work sync' to keep api/go.mod consistent with the transitive
dependency updates from the main module (golang.org/x/* version bumps
pulled in by the moby/spdystream and opentelemetry upgrades).

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com>

* fix: add missing go.mod hash entries to api/go.sum

'go mod tidy' adds .mod file hash entries that 'go work sync' omits.
Required to satisfy the check-golang-version CI validation.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>

Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com>

---------

Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com>

* ci(issue-triage): add reusable workflow from DataDog/issue-triage-action (#3187)

* ci(issue-triage): add reusable workflow from DataDog/issue-triage-action

Add issue triage workflow that delegates to the shared reusable action at
DataDog/issue-triage-action v1.0.0. On each new issue the workflow runs
Claude-based triage, applies a team label, and sends a Slack notification.

* Use the good commit

* [CONTP-1785] Replace container image with name in DDI check section (#3196)

Add DatadogInstrumentation check containerName

chore: update config sample

Co-authored-by: mathew.estafanous <mathew.estafanous@datadoghq.com>

* Update Operator Release Workflows (#3060)

* sync operator release workflow

* simplify diff detection

* Add DatadogInstrumentation logs config (#3198)

Add DatadogInstrumentation logs config

Co-authored-by: mathew.estafanous <mathew.estafanous@datadoghq.com>

---------

Co-authored-by: Antonio Mejia <antonio.mejia@datadoghq.com>
Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com>
Co-authored-by: dd-octo-sts-26fcfa[bot] <266798054+dd-octo-sts-26fcfa[bot]@users.noreply.github.com>
Co-authored-by: Nicolas Schweitzer <nicolas.schweitzer@datadoghq.com>
Co-authored-by: Mathew Estafanous <56979977+Mathew-Estafanous@users.noreply.github.com>
Co-authored-by: mathew.estafanous <mathew.estafanous@datadoghq.com>
Co-authored-by: Gabriel Dos Santos <91925154+gabedos@users.noreply.github.com>
Co-authored-by: Claude <claude@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants