[CASCL-1386] (10/11) Evict Karpenter user NodePools#3177
Draft
L3n41c wants to merge 1 commit into
Draft
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lenaic/CASCL-1386-evict-09-standalone #3177 +/- ##
=========================================================================
+ Coverage 44.41% 44.42% +0.01%
=========================================================================
Files 391 391
Lines 31316 31322 +6
=========================================================================
+ Hits 13908 13914 +6
+ Misses 16509 16508 -1
- Partials 899 900 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
e6ebd52 to
c0b814f
Compare
97fffd2 to
c3fcaa0
Compare
c0b814f to
08904e2
Compare
403189a to
ae903f8
Compare
08904e2 to
43a0d78
Compare
5 tasks
ae903f8 to
4e1f9b8
Compare
43a0d78 to
1505efe
Compare
4e1f9b8 to
e551e5a
Compare
045f39b to
f21be8d
Compare
e551e5a to
a29e4e3
Compare
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
f21be8d to
4fbbbac
Compare
a29e4e3 to
05eef42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements Karpenter user NodePool eviction: cordon and drain (Karpenter reclaims the emptied instances).
Motivation
PR #3026 is too large to review as a single change. This is part 10 of 11 of a stack that splits it into small, individually-reviewable pieces that each build and pass tests on their own. See #3026 for the full feature context and end-to-end QA.
Additional Notes
Stacked PR — the base branch is
lenaic/CASCL-1386-evict-09-standalone, notmain, so the diff shows only this step's change. Reuses the drain primitives introduced in part 8. The code is taken verbatim from #3026 (rebased ontomain); there are no logic changes versus #3026.Minimum Agent Versions
N/A —
kubectl-datadogplugin only.Describe your test plan
go test ./cmd/kubectl-datadog/autoscaling/cluster/...passes at this commit. Full end-to-end QA is tracked on #3026.Checklist
qa/skip-qalabel applied (not independently shippable; QA tracked on [CASCL-1386] Add evict-legacy-nodes subcommand to drain non-Datadog node groups #3026)