Skip to content

[CASCL-1386] (7/11) Evict EKS managed node groups#3174

Draft
L3n41c wants to merge 1 commit into
lenaic/CASCL-1386-evict-06-ec2-instance-id-helperfrom
lenaic/CASCL-1386-evict-07-eks-mng
Draft

[CASCL-1386] (7/11) Evict EKS managed node groups#3174
L3n41c wants to merge 1 commit into
lenaic/CASCL-1386-evict-06-ec2-instance-id-helperfrom
lenaic/CASCL-1386-evict-07-eks-mng

Conversation

@L3n41c

@L3n41c L3n41c commented Jun 18, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Implements EKS managed node group eviction (scale-to-zero then wait; EKS drains pods server-side, so it needs no client-side drain primitives).

Motivation

PR #3026 is too large to review as a single change. This is part 7 of 11 of a stack that splits it into small, individually-reviewable pieces that each build and pass tests on their own. See #3026 for the full feature context and end-to-end QA.

Additional Notes

Stacked PR — the base branch is lenaic/CASCL-1386-evict-06-ec2-instance-id-helper, not main, so the diff shows only this step's change. Implements an evictor the skeleton (part 1) left stubbed. The code is taken verbatim from #3026 (rebased onto main); there are no logic changes versus #3026.

Minimum Agent Versions

N/A — kubectl-datadog plugin only.

Describe your test plan

go test ./cmd/kubectl-datadog/autoscaling/cluster/... passes at this commit. Full end-to-end QA is tracked on #3026.

Checklist

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jun 18, 2026

Copy link
Copy Markdown

Code Coverage

🎯 Code Coverage (details)
Patch Coverage: 94.87%
Overall Coverage: 44.35% (+0.07%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8e43ad1 | Docs | Datadog PR Page | Give us feedback!

@codecov-commenter

codecov-commenter commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.11%. Comparing base (06f31c4) to head (8e43ad1).

Files with missing lines Patch % Lines
...bectl-datadog/autoscaling/cluster/evict/eks_mng.go 95.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                                  Coverage Diff                                  @@
##           lenaic/CASCL-1386-evict-06-ec2-instance-id-helper    #3174      +/-   ##
=====================================================================================
+ Coverage                                              44.04%   44.11%   +0.07%     
=====================================================================================
  Files                                                    389      389              
  Lines                                                  31080    31119      +39     
=====================================================================================
+ Hits                                                   13690    13729      +39     
  Misses                                                 16498    16498              
  Partials                                                 892      892              
Flag Coverage Δ
unittests 44.11% <95.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...bectl-datadog/autoscaling/cluster/evict/eks_mng.go 95.12% <95.00%> (+95.12%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06f31c4...8e43ad1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@L3n41c L3n41c force-pushed the lenaic/CASCL-1386-evict-07-eks-mng branch from c0c8b6a to 9250b71 Compare June 19, 2026 14:21
@L3n41c L3n41c force-pushed the lenaic/CASCL-1386-evict-06-ec2-instance-id-helper branch from dd81350 to 0f545f7 Compare June 19, 2026 14:21
@L3n41c L3n41c force-pushed the lenaic/CASCL-1386-evict-07-eks-mng branch from 9250b71 to f9c10d1 Compare June 22, 2026 13:24
@L3n41c L3n41c force-pushed the lenaic/CASCL-1386-evict-06-ec2-instance-id-helper branch from 0f545f7 to 3b7cda6 Compare June 22, 2026 13:25
Part of a stack splitting #3026 (too large to review in one piece) into
small pieces that each build and pass tests on their own. The command is
fully functional only once the whole stack lands.
@L3n41c L3n41c force-pushed the lenaic/CASCL-1386-evict-07-eks-mng branch from f9c10d1 to 8e43ad1 Compare June 23, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants