Skip to content

[CASCL-1386] Harmonize impact-list bullet styles in cluster uninstall#3172

Open
L3n41c wants to merge 1 commit into
mainfrom
lenaic/CASCL-1386-uninstall-bullets
Open

[CASCL-1386] Harmonize impact-list bullet styles in cluster uninstall#3172
L3n41c wants to merge 1 commit into
mainfrom
lenaic/CASCL-1386-uninstall-bullets

Conversation

@L3n41c

@L3n41c L3n41c commented Jun 18, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Harmonizes the impact-list bullet style in the kubectl datadog autoscaling cluster uninstall command: first-level items use (U+2022) and second-level items use (U+25E6), matching the style introduced for evict-legacy-nodes.

Motivation

Both commands print a two-level impact summary; this keeps their bullet styles consistent. Cosmetic only.

Additional Notes

Split out of #3026 as an independent change (targets main directly). No behavior change.

Minimum Agent Versions

N/A — kubectl-datadog plugin only.

Describe your test plan

go build ./cmd/kubectl-datadog/... passes; output-only change.

Checklist

  • PR has at least one valid label
  • qa/skip-qa label applied
  • All commits are signed

Use • (U+2022) for first-level items and ◦ (U+25E6) for second-level
items in the uninstall command's impact summary, matching the style used
by the evict-legacy-nodes command. Cosmetic only.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jun 18, 2026

Copy link
Copy Markdown

Code Coverage

Fix all issues with BitsAI

🛑 Gate Violations

🎯 1 Code Coverage issue detected

A Patch coverage percentage gate may be blocking this PR.

Patch coverage: 0.00% (threshold: 80.00%)

ℹ️ Info

🎯 Code Coverage (details)
Patch Coverage: 0.00%
Overall Coverage: 44.27% (+0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b28e6e6 | Docs | Datadog PR Page | Give us feedback!

@codecov-commenter

codecov-commenter commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.03%. Comparing base (92788bf) to head (b28e6e6).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...datadog/autoscaling/cluster/uninstall/uninstall.go 0.00% 19 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3172   +/-   ##
=======================================
  Coverage   44.03%   44.03%           
=======================================
  Files         377      377           
  Lines       30713    30713           
=======================================
  Hits        13525    13525           
  Misses      16300    16300           
  Partials      888      888           
Flag Coverage Δ
unittests 44.03% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...datadog/autoscaling/cluster/uninstall/uninstall.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92788bf...b28e6e6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@L3n41c L3n41c marked this pull request as ready for review June 23, 2026 09:03
@L3n41c L3n41c requested review from a team as code owners June 23, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants