[CASCL-1386] (2/11) Build the evict-legacy-nodes execution plan#3161
Open
L3n41c wants to merge 1 commit into
Open
[CASCL-1386] (2/11) Build the evict-legacy-nodes execution plan#3161L3n41c wants to merge 1 commit into
L3n41c wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
1ea5ce0 to
2491129
Compare
aa51aa3 to
1d6af4f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lenaic/CASCL-1386-evict-01-skeleton #3161 +/- ##
=======================================================================
+ Coverage 43.74% 43.90% +0.16%
=======================================================================
Files 388 388
Lines 30950 31005 +55
=======================================================================
+ Hits 13538 13614 +76
+ Misses 16524 16501 -23
- Partials 888 890 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
1d6af4f to
e709803
Compare
66cb71f to
a97a49e
Compare
e709803 to
5100da9
Compare
5 tasks
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
5100da9 to
67c1c0b
Compare
AlexanderYastrebov
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements
BuildPlan: computes which node groups (targets) to drain from the cluster snapshot, filtering out Datadog-managed entities.Motivation
PR #3026 is too large to review as a single change. This is part 2 of 11 of a stack that splits it into small, individually-reviewable pieces that each build and pass tests on their own. See #3026 for the full feature context and end-to-end QA.
Additional Notes
Stacked PR — the base branch is
lenaic/CASCL-1386-evict-01-skeleton, notmain, so the diff shows only this step's change. Implements logic the skeleton (part 1) left stubbed. The code is taken verbatim from #3026 (rebased ontomain); there are no logic changes versus #3026.Minimum Agent Versions
N/A —
kubectl-datadogplugin only.Describe your test plan
go test ./cmd/kubectl-datadog/autoscaling/cluster/...passes at this commit. Full end-to-end QA is tracked on #3026.Checklist
qa/skip-qalabel applied (not independently shippable; QA tracked on [CASCL-1386] Add evict-legacy-nodes subcommand to drain non-Datadog node groups #3026)