Skip to content

Add dd-octo-sts trust policy for release-dashboard-api on us1.ddbuild.io#52827

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
antonio.mejia/release-dashboard-api-ddbuild
Jun 26, 2026
Merged

Add dd-octo-sts trust policy for release-dashboard-api on us1.ddbuild.io#52827
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
antonio.mejia/release-dashboard-api-ddbuild

Conversation

@dd-anmejia

@dd-anmejia dd-anmejia commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds .github/chainguard/release-dashboard-api-ddbuild.sts.yaml trust policy authorizing the release-dashboard-api service on us1.ddbuild.io to read repository contents and pull requests via dd-octo-sts
  • Uses vault.us1.ddbuild.io issuer and the ddbuild Vault UUID, following the same permissions (contents: read, pull_requests: read) as the existing prod and staging policies

Related PRs

Merge order

  1. Merge this PR and the operator trust policy PR first — the policy must be on the default branch before the service can exchange tokens
  2. Then merge the allowlist and policy selector PRs

Test plan

  • Verify "Trust Policy Validation" CI check passes on this PR

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@dd-anmejia dd-anmejia requested a review from a team as a code owner June 25, 2026 21:38
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-devx labels Jun 25, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Jun 25, 2026
@dd-anmejia dd-anmejia added qa/skip-qa changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Jun 25, 2026
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 51.12% (+0.12%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 73a82e7 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor bb3236c6:

Results for datadog-agent_7.82.0~devel.git.376.73a82e7.pipeline.121177948-1_amd64.deb:

No change detected

@dd-anmejia

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 26, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-26 13:03:01 UTC ℹ️ Start processing command /merge


2026-06-26 13:03:06 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 2h (p90).


2026-06-26 15:07:48 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 4f9c96d into main Jun 26, 2026
273 of 287 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the antonio.mejia/release-dashboard-api-ddbuild branch June 26, 2026 15:07
@github-actions github-actions Bot added this to the 7.82.0 milestone Jun 26, 2026
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: aa7030c2-d95c-4245-aaa4-ce0b92b7450e

Baseline: 73fc2ca
Comparison: 4f9c96d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +0.44 [+0.20, +0.69] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.36 [+0.32, +0.40] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.30 [+0.24, +0.36] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.15 [+0.10, +0.20] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.06 [-0.16, +0.03] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -0.10 [-0.15, -0.06] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.35 [-1.44, +0.74] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 145.27MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 576.39KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 485.23MiB ≤ 495MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 0.89MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 182.28MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.18MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 342.19 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 390.16MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.86GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 29.90 ≤ 40 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 299.19MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 61.87 ≤ 80 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 276.94MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 22.77 ≤ 40 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 284.81MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle comparison 10 Oom killed Debug Dashboard
quality_gate_security_no_fs_load baseline 10 Oom killed Debug Dashboard
quality_gate_security_no_fs_load comparison 10 Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation qa/skip-qa short review PR is simple enough to be reviewed quickly team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants