get2FAUnauthenticatedStatus cleaning - #409
Merged
ptournem-dashlane merged 5 commits intoJul 31, 2026
Merged
Conversation
…interactive device
ptournem-dashlane
marked this pull request as draft
July 30, 2026 10:08
…ren types of the response
ptournem-dashlane
requested review from
arenault-dashlane,
elemaistre-dashlane,
jarroyorodriguez-dashlane and
srobakidze-dashlane
July 30, 2026 16:13
srobakidze-dashlane
approved these changes
Jul 31, 2026
ptournem-dashlane
marked this pull request as ready for review
July 31, 2026 08:02
ptournem-dashlane
deleted the
feature/2FA-without-unauthenticated-endpoint
branch
July 31, 2026 10:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The endpoint
get2FAUnauthenticatedStatusis going to be removed so we need to replace its usage with data coming fromgetAuthenticationMethodsChanges
This MR :
getAuthenticationMethodsendpoint definition to export the inner types of the responsegetRemoteAuthenticationAndSSOInfohelper to retrieve information needed for 2FA and SSO based on thegetAuthenticationMethodsendpoint's resultget2FAUnauthenticatedStatusbygetRemoteAuthenticationAndSSOInfoget2FAUnauthenticatedStatusTesting
Test done on :