Skip to content

get2FAUnauthenticatedStatus cleaning - #409

Merged
ptournem-dashlane merged 5 commits into
masterfrom
feature/2FA-without-unauthenticated-endpoint
Jul 31, 2026
Merged

get2FAUnauthenticatedStatus cleaning#409
ptournem-dashlane merged 5 commits into
masterfrom
feature/2FA-without-unauthenticated-endpoint

Conversation

@ptournem-dashlane

@ptournem-dashlane ptournem-dashlane commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Context

The endpoint get2FAUnauthenticatedStatus is going to be removed so we need to replace its usage with data coming from getAuthenticationMethods

Changes

This MR :

  • Refactors non-interactive device registration to stop using get2FAUnauthenticatedStatus
  • Updates getAuthenticationMethods endpoint definition to export the inner types of the response
  • Adds a getRemoteAuthenticationAndSSOInfo helper to retrieve information needed for 2FA and SSO based on the getAuthenticationMethods endpoint's result
  • Replaces usage of get2FAUnauthenticatedStatus by getRemoteAuthenticationAndSSOInfo
  • Removes get2FAUnauthenticatedStatus

Testing

Test done on :

  • Non 2FA accounts
  • SSO accounts
  • 2FA new device accounts
  • 2FA login accounts
  • SK / MPless accounts
  • B2B MP account with team enforcing 2FA

@ptournem-dashlane
ptournem-dashlane marked this pull request as draft July 30, 2026 10:08
@ptournem-dashlane
ptournem-dashlane marked this pull request as ready for review July 31, 2026 08:02
@ptournem-dashlane
ptournem-dashlane merged commit af435cd into master Jul 31, 2026
4 checks passed
@ptournem-dashlane
ptournem-dashlane deleted the feature/2FA-without-unauthenticated-endpoint branch July 31, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants