Conversation
- Renamed all occurences of ```Documentor``` by ```Documentator``` - Renamed file ```src/Ripcord/Documentor.php``` by ```src/Ripcord/Documentator.php``` - Fixed file ```composer.json```
Author
|
How can I fix continuous integration checks? |
DarkaOnLine
requested changes
Jul 8, 2020
added 3 commits
July 8, 2020 10:59
Renamed all occurences of ```Documentator``` by ```Documentor``` to avoid break compatibility.
- Renamed ```Documentator``` class to ```Documentor```
Author
|
It seems not possible to avoid all BC breaks due to the folder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #18
Reason
All classes in folder
src/Ripcord/Documentorandsrc/Ripcord/Parsershave a wrong namespace definition following psr-4 specifications for classes autoloading.Resolution
DocumentatorbyDocumentorComments
I had to choice between words
DocumentorandDocumentator.Edit
The word
Documentorwas choosen to avoid BC break.