Skip to content

“At most” value display can slightly understate the actual maximum #11

Open

Description

@KillariDev

The ETH formatter truncates to six decimal places, while the UI labels the displayed amount as “at most.” The exact transaction value can therefore be slightly greater than the displayed number—by less than 0.000001 ETH. The 2% buffer calculation also rounds downward by up to one wei.

Use one of these alternatives:

round the displayed maximum upward
display more decimal places
say “approximately”
show the exact amount in an expandable transaction-details section

The wallet confirmation still displays the actual transaction value, so this is primarily a precision and trust issue.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions