This repository was archived by the owner on Jun 22, 2021. It is now read-only.
re-introduce throttle checking#13
Open
bvogel wants to merge 27 commits into
Open
Conversation
…s low Avoid "short period write limit reached" request errors
Co-Authored-By: Carlos I. Garcia <charlie.igg@gmail.com>
feat: Add delay to plenty requests when plenty's Short-Period-Decay is low
fix: remove false delay
…ntact-address fix: fix typo when creating contact address
…y group api endpoint
feat: v2 endpoints for property group
feat: prop group name endpoints
feat: pim endpoints
refactor: adjust namespace for PIM endpoints
Without an explicit timeout, an unresponsive Plenty endpoint blocks the caller indefinitely (the socket never errors, so the built-in retry middleware never fires). Add Config.open_timeout (default 5s) and Config.timeout (default 30s, per page request), applied to the Faraday connection in #perform; both overridable at runtime via the Config writers. Verified in Ruby 2.7.1 + Faraday 1.1.0 (production parity) via Docker: rspec config_spec + request_spec => 50 examples, 0 failures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat: add configurable HTTP request timeouts
fix: request retry mechanism added to gem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.