Skip to content

Revert KubeJS compatibility changes - #762

Merged
DaFuqs merged 3 commits into
DaFuqs:1.20.1-aria-for-paintersfrom
unilock:1.20.1-aria-for-painters
Sep 7, 2025
Merged

DaFuqs merged 3 commits into
DaFuqs:1.20.1-aria-for-paintersfrom
unilock:1.20.1-aria-for-painters

Conversation

@unilock

@unilock unilock commented Aug 31, 2025

Copy link
Copy Markdown
Contributor

Fixes enchantment upgrade recipes disappearing upon reload (#460)

Tested and working with KubeJS - I guess they stopped doing whatever horrible thing they were doing to break this in the first place

Fixes enchantment upgrade recipes disappearing upon reload (#460)

Tested and working with KubeJS - I guess they stopped doing whatever horrible thing they were doing to break this in the first place
@DaFuqs

DaFuqs commented Sep 6, 2025

Copy link
Copy Markdown
Owner

https://github.com/KubeJS-Mods/KubeJS/blob/2001/common/src/main/java/dev/latvian/mods/kubejs/core/mixin/common/RecipeManagerMixin.java

The logic definitely changed from last time I looked at it.

There still is a cancel, but only a conditional one, now. Did you test with and without custom recipes added? (or whatever registers ServerEvents.RECIPES? If it works even with that I have no issues ditching the current ugly workaround.

@unilock

unilock commented Sep 6, 2025 •

Copy link
Copy Markdown
Contributor Author

I don't think I need to test it to know that using KubeJS to modify recipes will break things. I am more than somewhat tempted to mixin into KubeJS out of spite. But I guess it would be better to just implement KubeJSPlugin#injectRuntimeRecipes in a mod compat class at this point.

@DaFuqs

DaFuqs commented Sep 7, 2025

Copy link
Copy Markdown
Owner

I am more than somewhat tempted to mixin into KubeJS out of spite

mood

@DaFuqs

DaFuqs commented Sep 7, 2025

Copy link
Copy Markdown
Owner

Since KubeJS did never release for fabric 1.21.1+ we don't have to worry about that (for now). I'll keep an eye out regardless.

I'll merge this and create a release real quick. Thank you!

@DaFuqs
DaFuqs merged commit 2a36f40 into DaFuqs:1.20.1-aria-for-painters Sep 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants