Repository navigation
fix(LOC_BUILDER_DD): accept zero and reject missing coordinates - #5027
Merged
TomOnTime merged 1 commit intoOct 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LOC_BUILDER_DD({label: "site", x: 51.5, alt: 0})passesdnscontrol checkandprint-iremits a LOC record at longitude zero, althoughyis required. Conversely,{label: "origin", x: 0, y: 0, alt: 0}stops withLOC_BUILDER_DD requires x and y elements; it should produce the zero-coordinate LOC record.The guard treats coordinates as booleans, and uses
&&, so it rejects two zero values while accepting either missing property.The fix checks each property for
undefined.TestLOCBuilderDDCoordinatescovers the valid zero pair and each missing property.On the base commit all three regression rows fail. On the final tree the focused test passed three of three runs, and the package passed.