Add external IDs in search API results - #191
Open
jmsevin wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to how document external IDs are handled and returned throughout the backend, especially in the search service. It adds support for fetching and including
external_idfields for documents in search results, updates database queries and models accordingly, and improves test coverage for these changes. There are also minor code style and refactoring improvements.Document external ID support:
document_external_idfield to theDocumentPayloadModeland ensured it's populated in payloads returned fromget_documents_payload_by_ids_sync. [1] [2]get_external_ids_by_document_ids_syncto efficiently fetch external IDs for a list of document IDs.document_external_idby calling the new function and updating the payload for each result. [1] [2] [3] [4]Testing improvements:
external_id, ensuring the new field is handled correctly. [1] [2]Build and code quality improvements:
Makefileto introduce agenerate-bamltarget and ensure code generation is run before development, test, and poetry commands.