Fully Integrate Ambient Occlusion#104
Merged
Merged
Conversation
CubeBerry
commented
May 19, 2026
CubeBerry
commented
Owner
- FIxed several issues occured during process of merging ambient occlusion feature.
- Fixed GetViewMatrix and GetProjectionMatrix calls on CameraManager which were removed in the multi-camera refactor. Replaced with calls on a Camera* pointer, falling back to the main camera if none is provided. - Fixed DXSSAOContext::Execute override error by updating its signature to match the IRenderContext base class.
- m_ssaoContext->Execute was missing from the deferred render loop. Without it, the AO texture remained all-white and produced no occlusion. Added the call between GBuffer and GlobalLighting passes.
doyoung413
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.