test(web): strip COTAL_ before the rejection arm's env spread - #901
Merged
Conversation
The rejection arm added for the named-refusal fix spawns the web child with
`{ ...process.env, COTAL_WEB_SMOKE_REJECT_HISTORY: "1" }`. Whatever runs a
suite may be a managed agent session, so an unfiltered spread hands that child
a live credential and a live broker URL, and it would talk to the operator's
mesh instead of the suite's throwaway one.
smoke:suite-ambient-env is the census that exists to catch exactly this, and it
named this file on main. Strip the COTAL_ keys from the copy first, using the
same idiom the compliant suites already use, then set the one flag the arm
needs.
Verified: smoke:suite-ambient-env PASS, with the file now listed under "strips
COTAL_ before the spread"; smoke:web-bounded-aggregation 43 passed, 0 failed,
the same count as before, so no cell was lost.
Contributor
Author
|
APPROVE Graded exact SHA Verified:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red on shard 2 at
smoke:suite-ambient-env, and #898 caused it. This is the repair.What broke
The rejection arm #898 added spawns the web child with an unfiltered spread:
smoke:suite-ambient-envexists to refuse exactly that, and it named the file on main ata268c8dbe(run 32977375051, shard 2, job 98205295502):The census's own wording is the reason it matters: whatever runs a suite may be a managed agent
session, so the spread hands the child a live credential and a live broker URL, and the child talks
to the operator's mesh instead of the suite's throwaway one.
The fix
Strip
COTAL_from the copy before the spread, using the idiom the compliant suites already use(
attach-auth-root.smoke.ts:107,control-transport-dial.smoke.ts:51,discovery-bundle-consumable.smoke.ts:89), then set the one flag the arm needs. Not added toREVIEWEDand not toFROZEN— the census is explicit thatFROZENis a baseline rather than aplace for new entries, and this child genuinely should not inherit connection material.
Verification
smoke:suite-ambient-env: PASS, with the file now listed understrips COTAL_ before the spreadrather than in the assertion.smoke:web-bounded-aggregation: 43 passed, 0 failed — the same count as before the change, sono cell was lost and fix(web): name rejected history reads #898's rejection cells still hold.
Why it got through
Worth recording rather than just fixing, because this is the second time the same census has caught
the same class from the same direction. #454 did it with
console-auth.smoke.ts; this isbounded-aggregation.smoke.ts. Both times a web smoke gained a child-spawning arm, and both timesthe review checked the sibling web suites and not the census that governs child spawning. The
sibling suites cannot catch it — only
smoke:suite-ambient-envcan, and it lives on a differentshard.
The durable form: a change that gives any suite a new child process must run
smoke:suite-ambient-envbefore merge, regardless of what else passes.