test(delivery): isolate the seed store in the adoption-doctor e2e smoke - #832
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smoke:adoption-doctor-e2ehad noXDG_CONFIG_HOMEisolation, so it graded the operator's machine as much as the code.The connector seed store does not live under
COTAL_HOME— it sits underglobalConfigDir(), which is the real~/.config/cotalunlessXDG_CONFIG_HOMEsays otherwise. Everycotalinvocation in this suite (the delivery daemon and eachdoctor auth) runs the seed reconcile, and that refuses outright when the store's generation is newer than the binary being run. On any box whose store was stamped by a later release than the tip under test, three cells red withthis cotal X is older than the seed store's generation Y— which reads exactly like a behaviour failure and is not one.Its sibling
implementations/manager/smoke/attach-reconnect.smoke.tsalready documents and applies this. This is the same guard, in the same shape.Evidence — red first, then green, against the same poisoned store. The version premise did not hold on a plain run here (this box's store is stamped
0.28.2and the branch is also0.28.2, so the refusal cannot fire, and the suite passed 3/3 un-isolated). Rather than fix an unreproduced failure, the condition was forced: a throwawayXDG_CONFIG_HOMEcontainingcotal/seed/stamp.jsonat generation99.0.0, leaving the real store untouched.rc=1,✗ E2E DOCTOR-BINARY 7/10, three cells carryingthis cotal 0.28.2 is older than the seed store's generation 99.0.0.rc=0,✓ E2E DOCTOR-BINARY 10/10, zero refusal lines — 3 runs each way.The count is asserted as 10/10, so a cell that silently stops running still reddens.
Test-only; no shipped package changes.