fix(cli): supervise and deliver resolve the registered mesh instead of defaulting to loopback - #762
Closed
davidfarah2003 wants to merge 11 commits into
Closed
fix(cli): supervise and deliver resolve the registered mesh instead of defaulting to loopback#762davidfarah2003 wants to merge 11 commits into
davidfarah2003 wants to merge 11 commits into
Conversation
Contributor
Author
|
Closing as superseded: the supervise side landed via #849 (0def128 — supervise resolves the registered mesh target and explains remote host authority), and the deliver side is actively being repaired in #847 (delivery launched with the mesh's transport). The approach here (resolveTargetOrExit/preflightOrExit) conflicts structurally with the landed superviseTarget flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #756.
cotal superviseandcotal deliverignored the mesh registry and dialednats://127.0.0.1:4222when--serverwas absent, so a hand-registered mesh on a non-default broker failed with a misleading "Can't reach NATS ... Run: cotal up" while the registered broker was live.supervisenow resolves and preflights the registered mesh via the workspace registry, carries the resolved root intoManager, and records its pid under that root.deliverwithout--serverresolves/preflights the registered mesh and uses its root for daemon creds and the scan target. An explicit--serverkeeps the prior standalone override; injected secret-store hosting stays separate from workstation registry resolution.docs/cli.mdupdated in the same change.Verification: reproduced live before the fix (hand-registered mesh on a random port;
superviserc=1 dialing loopback), green after on the same shape. New CI-gatedsmoke:recovery-registry:liveruns a live non-default JetStream broker, a hand-registered mesh, and the real CLI entry points, with explicit no-loopback checks and offline recorded-URL refusal checks. Two mutation proofs kill on the named assertions (supervise dials the registered broker;offline delivery refuses naming its recorded URL). typecheck/build/changeset all clean; delivery renewal, store-boundary, and server-resolution live smokes pass.