Open
Conversation
The pin's comment attributes it to "sf_tools/python-pysap importing
pkg_resources", but direct testing in the shapepipe container shows:
- `sf_tools` 2.0.4 imports cleanly on setuptools 82 (no pkg_resources
reference in its source).
- `python-pysap` master has no `pkg_resources` usage in either its
package `__init__.py` or `setup.py`.
- The only runtime dependency in the shapepipe stack that actually used
`pkg_resources` (via `pkg_resources.get_distribution("sip_tpv")`) was
`sip_tpv`, which was removed from shapepipe entirely in #716.
So the historical need for the pin was sip_tpv, mis-attributed at
commit time. Post-#716 there's no remaining shapepipe dep that needs
pkg_resources, so the pin is dead.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pin's comment attributes it to "sf_tools/python-pysap importing pkg_resources", but both claims are wrong. Empirical check in the current shapepipe container:
sf_tools 2.0.4imports cleanly onsetuptools 82.0.0python-pysaphas nopkg_resourcesusage on masterpkg_resourceswassip_tpv(viapkg_resources.get_distribution("sip_tpv")in__init__.py), which was removed in refactor: drop sip_tpv, rely on astropy for TPV WCS (closes #713) #716So the real historical reason for the pin was
sip_tpv, mis-attributed in the comment. Post-#716 there's no remaining shapepipe runtime dep that needspkg_resources, so the pin is dead.Should arguably have been included in #716 — here we are.
Test plan
sf_toolsimports on setuptools 82 in the current containerpython-pysapsource inspection (master) — nopkg_resourcesusageshapepipe_run -c example/config.iniruns after the pin is removed (CI will verify)🤖 Generated with Claude Code