docs: quote boolean in GitHub Enterprise Cloud deployment sample - #481
Merged
Conversation
metadata.labels is map[string]string; unquoted true fails to unmarshal. Introduced in yesterday's private-key-mount PR (59c4d11). Registry's stable doc is stale on the whole self-hosted K8s manifest section (still shows the old bash-env-var deployment with no explanation of how the private key file gets mounted) - not adopting that reversion. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quotes
baton: true→baton: "true"in the Deployment sample's pod label —metadata.labelsismap[string]string, so unquotedtruefails to unmarshal. Introduced yesterday in the private-key-mount PR (#465).Not adopting the registry's stale reversion of the whole self-hosted Kubernetes manifest section — the registry doc still has the old bash-env-var deployment instructions with no explanation of how the GitHub App private key file actually gets mounted, which #465 specifically fixed.
Test plan