chore: update Go toolchain and dependencies to fix security advisories - #97
Conversation
|
Heads up: `test-cloud-version` is failing here with a real `401 Unauthorized` from the live GitLab.com API (`GET /api/v4/groups` for `ci_test_group`), reproduced on rerun (not a flake). This looks unrelated to the dependency bump in this PR:
Most likely the CI `BATON_ACCESS_TOKEN` secret (a GitLab.com PAT for the `ci_test_group` test account) has expired or been revoked. That's an org-owned credential I don't have access to rotate — flagging so whoever owns it can refresh it. Happy to re-run this job once it's updated. |
Connector PR Review: chore: update Go toolchain and dependencies to fix security advisoriesBlocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummaryScanned the complete 89-line PR diff ( Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
…isories Rebased on top of main, which already carries the Go 1.25.13 toolchain bump via the .versions.yaml/baton-admin sync (CXP-920). Remaining scope: - Bump github.com/klauspost/compress v1.18.6 -> v1.18.7 (GO-2026-5841, OOB read in s2). - Bump go.mongodb.org/mongo-driver v1.17.4 -> v1.17.7 (GO-2026-5327, heap OOB read in GSSAPI error handling). Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
8ece968 to
4fb5f17
Compare
Summary
A customer report (CXP-920) flagged that this connector's image/dependencies are old enough to have active vulnerabilities. The Go toolchain part of that (bumping to 1.25.13, which resolves the govulncheck-flagged stdlib CVEs) already landed on
mainvia the.versions.yaml/baton-admin sync, so this PR is now rebased on top of that and scoped to just the remaining leaf-dependency fixes:github.com/klauspost/compressv1.18.6 -> v1.18.7 (GO-2026-5841, OOB read ins2).go.mongodb.org/mongo-driverv1.17.4 -> v1.17.7 (GO-2026-5327, heap OOB read in GSSAPI error handling).go mod tidy && go mod vendorto syncgo.sum/vendor/.One advisory remains: GO-2026-5932 (
golang.org/x/crypto/openpgpis unmaintained/unsafe by design) has no fix available upstream.govulncheckconfirms this connector's code does not call the affected symbols — it's a dead transitive dependency of another module. Flagging for visibility; no action possible here short of that upstream dependency dropping the package.Test plan
go build ./...go vet ./...golangci-lint run ./...— 0 issuesgo test ./...— no test files in this repo, ran cleangovulncheck ./...(run explicitly under the Go 1.25.13 toolchain): 0 reachable vulnerabilities, 1 unreached/unfixable module vuln (x/crypto/openpgp, see above).versions.yamluntouched (baton-sdk pin unaffected, matchescheck-versions.yamlCI gate)