[CXH-2209] fix: gate clm_role on CLM availability, narrow opt-in error tolerance, log skipped folder-security entries - #64

Open

FeliLucero1 wants to merge 39 commits into

clm-folder-provisioning-external-idfrom

clm-role-optin-error-observability-fixes

Commits on Aug 18, 2026

fix: gate clm_role on CLM availability, narrow opt-in error tolerance, log skipped folder-security entries

FeliLucero1
and
claude
committed
93b272d
fix: revert opt-in-error narrowing, log instead of gate on error source

FeliLucero1
and
claude
committed
f2c7868
fix: address current bot review findings on PR #64

FeliLucero1
and
claude
committed
2b32bd4
fix: suppress expected-state Debug logs diluting the AccessType skip signal
FeliLucero1
committed
4064dd6
fix: narrow clm_role's CLM-availability tolerance to discovery errors only
FeliLucero1
committed
a411685
fix: require isOptInFeatureUnavailableError alongside IsClmDiscoveryError
FeliLucero1
committed
6999103
fix: clmIsBenignUnmappedAccessType doc/test correctness (no log-level change)
FeliLucero1
committed
0228742
fix: pin which entry logs in the AccessType-skip test, not just how many
FeliLucero1
committed
2f3ef92
test: cover the other half of clm_role's two-condition CLM-availability gate
FeliLucero1
committed
ab31f84
fix: carry CLM-discovery source as a log field, not a log level
FeliLucero1
committed
a75d30f
fix: drop clmDiscoverySourceField — the error text already says why
FeliLucero1
committed
5454660
test: cover Roles/Users branches for the AccessType-skip log; fix ForceClmDiscoveryStatus doc
FeliLucero1
committed
d998f0a
test: assert each branch's distinguishing log field, not just count/access_type
FeliLucero1
committed
61a0da2
fix: address remaining PR #64 review threads
FeliLucero1
committed
d2e4157
test: bind unmapped-AccessType log assertions per-message, not set-cover
FeliLucero1
committed
1f26d75
refactor: dedupe folder-security skip logging into one helper
FeliLucero1
committed
e870dfe
fix: add missing access_type to unrecognized-role skip log; harden sample-branch Grant test
FeliLucero1
committed
c71b3b8
perf: stop building a per-kind message via fmt.Sprintf on every folder-security skip
FeliLucero1
committed
3cdd9bc
fix: close two gaps left by the previous skip-log pass
FeliLucero1
committed
154f7b4
fix: resolve duplicate sample-branch re-seed logic from rebase conflict
FeliLucero1
committed
5aed823
fix: apply the discovery-source two-conjunct gate to the other 4 CLM builders

FeliLucero1
and
claude
committed
360173b
revert: pull back the discovery-source gate from the 4 data-backed CLM builders

FeliLucero1
and
claude
committed
ffa3710
fix: fail loudly instead of silently skipping when an opt-in feature is unavailable

FeliLucero1
and
claude
committed
ef05cbd
fix: exclude CLM/signing-group risk from CI by pinning sync-resource-types

FeliLucero1
and
claude
committed
d9d00d0
refactor: drop dead CLM-discovery-error machinery, fix signing_group docs gap

FeliLucero1
and
claude
committed
86023fd
fix: drop dead conjunct and fix stale comments in folder-security logging

FeliLucero1
and
claude
committed
a29328e
docs: warn self-hosted/CLI users that OptInRequired doesn't protect them

FeliLucero1
and
claude
committed
1771362
test: add signing_groups_test.go, covering the new fail-loud behavior

FeliLucero1
and
claude
committed
f34d30f
fix: address bot review findings on PR #64, dedupe rewriteTransport

FeliLucero1
and
claude
committed
c1993d2
docs: warn maintainers that CI's resource-type allowlist needs updating

FeliLucero1
and
claude
committed
832692c
fix: serialize CI jobs that hit the shared DocuSign demo account

FeliLucero1
and
claude
committed
10bd0bf
fix: restore grpc codes/status imports dropped by the PR #64 rebase

FeliLucero1
and
claude
committed
38fe890
docs: dedupe BATON_SYNC_RESOURCE_TYPES into a workflow-level env block

FeliLucero1
and
claude
committed
71e6604
fix: centralize CLM and base-credential checks in Connector.Validate()

FeliLucero1
and
claude
committed
a6b4471
docs: narrow README's self-hosted/CLI language to the one-shot CLI case

FeliLucero1
and
claude
committed
d686dc3
fix: hoist ci.yaml's per-job concurrency block to workflow level

FeliLucero1
and
claude
committed
e537b38
fix: correct stale signingGroupResourceType registration comment

FeliLucero1
and
claude
committed
87adb41
fix: drop NewWithClient's self-contradictory compatibility rationale

FeliLucero1
and
claude
committed
6de1e1b
fix: delete dead NewWithClient constructor and its test

FeliLucero1
and
claude
committed
93755a1