[CXH-2208] fix: derive CLM hrefs for Grant/Revoke instead of requiring a profile field - #63

Open

FeliLucero1 wants to merge 42 commits into

mainfrom

clm-folder-provisioning-external-id

Commits on Aug 19, 2026

fix: carry CLM href via ExternalId instead of profile for Grant/Revoke

FeliLucero1
and
claude
authored
c5273e6
fix: carry CLM href via a raw annotation instead of deprecated ExternalId

FeliLucero1
and
claude
authored
9c672a4
fix: derive CLM group/member hrefs from ID instead of resource metadata

FeliLucero1
and
claude
authored
dcef0bb
fix: prefer real server-issued hrefs over derived ones on writes

FeliLucero1
and
claude
authored
59dba8a
fix: address deep-code-review findings on PR #63
FeliLucero1
authored
43d07cf
fix: address latest bot review findings on PR #63
FeliLucero1
authored
6e7b5b5
doc: confirm clmHrefWithID's path-prefix reuse against clm_models.go
FeliLucero1
authored
d544828
doc: confirm isOptInFeatureUnavailableError's NotFound rationale against official docs
FeliLucero1
authored
08f151d
fix: reject bare scheme+host samples in clmHrefWithID; preserve annos on href-resolution error
FeliLucero1
authored
a56ca85
fix: address remaining PR #63 review threads
FeliLucero1
authored
949672e
test: make the sample-branch Grant test actually pin sample-preference
FeliLucero1
authored
42db4b8
fix: validate newID and log unexpected sample-parse failures in clmHrefWithID
FeliLucero1
authored
fa794e7
refactor: dedupe GroupHref/MemberHref, sampleHrefs construction, and error prefixes
FeliLucero1
authored
07e8d06
test: make the folder-security SampleBranch test actually pin sample-preference
FeliLucero1
authored
5363992
fix: address 3 findings from the latest automated review pass
FeliLucero1
authored
b333dbe
fix: SetGroupHref fails loudly on a typo'd ID, matching its new siblings
FeliLucero1
authored
a71e90c
fix: address 3 more findings from the automated review pass
FeliLucero1
authored
699f1f1
fix: also exclude empty entry hrefs in clmSampleHrefsFrom
FeliLucero1
authored
2ad413c
fix: close clmPreferredHref's empty-id gap, fix stale Grant comment

FeliLucero1
and
claude
authored
d89cf73
fix: address bot review findings on PR #63

FeliLucero1
and
claude
authored
672b2d0
fix: reject empty principal ID in Grant, matching Revoke's guard

FeliLucero1
and
claude
authored
46655a3
fix: reject empty member/group ID in clmGroupBuilder Grant/Revoke

FeliLucero1
and
claude
authored
c3f07fe
fix: reject empty folder ID in clmFolderBuilder Grant/Revoke

FeliLucero1
and
claude
authored
e1d1c66
fix: use codes.InvalidArgument for provisioning validation errors; reject trailing-slash sample hrefs

FeliLucero1
and
claude
authored
af12f73
fix: use codes.InvalidArgument for remaining plain-Errorf validation errors

FeliLucero1
and
claude
authored
124bef5
fix: derive sibling hrefs from the parsed URL path, not the raw string

FeliLucero1
and
claude
authored
1165916
fix: serialize CI jobs that hit the shared DocuSign demo account

FeliLucero1
and
claude
authored
d0f44d7
fix: log clmPreferredHref's no-samples fallback at Debug

FeliLucero1
and
claude
authored
1a72aec
fix: silence staticcheck SA5011 false positives in clm_folders_test.go

FeliLucero1
and
claude
committed
a4c7cb8
fix: strip query/fragment from clmHrefWithID's derived href

FeliLucero1
and
claude
committed
71407ba
fix: propagate getAnnos in default branches, fix stale clmIDFromHref doc

FeliLucero1
and
claude
committed
e395125

Commits on Aug 20, 2026

fix: request impersonation scope for CLM, parse CLM's real error envelope

FeliLucero1
and
claude
committed
004b78b
fix: Message() empty-UserMessage fallback, stale impersonation-scope doc

FeliLucero1
and
claude
committed
fd579b2
fix: revert impersonation scope — confirmed JWT-Grant-only, not the real cause

FeliLucero1
and
claude
committed
a090a70
fix: rework SearchFolders on CLM's real async Task API, fix Security wire shape

FeliLucero1
and
claude
committed
c4416b2

Commits on Aug 21, 2026

fix: rework PatchFolderSecurity on CLM's ChangeSecurityTasks endpoint

FeliLucero1
and
claude
committed
aec02e0
fix: nest ChangeSecurityTasks' folder+security under Folder, not top-level

FeliLucero1
and
claude
committed
67f0a13
docs: align SearchFolders comments with CLM Folders:Search reference

FeliLucero1
and
cursoragent
committed
07d0337
chore: sync baton-sdk to v0.24.6 to match main

FeliLucero1
and
cursoragent
committed
c3e7d3a
chore: leave .versions.yaml on baton-admin pin for this branch

FeliLucero1
and
cursoragent
committed
749f98f
merge: main into clm-folder stack to pick up baton-sdk v0.24.6
FeliLucero1
committed
0cdf026
fix: fail loud when folder-search Result.Href is empty mid-pagination

FeliLucero1
and
cursoragent
committed
28a362f