Skip to content

Revert "Add web frontend for baton-demo database" - #139

Closed
jirwin wants to merge 1 commit into
mainfrom
revert-138-jirwin/demo-web-app
Closed

jirwin wants to merge 1 commit into
mainfrom
revert-138-jirwin/demo-web-app

Conversation

@jirwin

@jirwin jirwin commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Reverts #138

@jirwin jirwin closed this Sep 23, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@github-actions

Copy link
Copy Markdown
Contributor

Connector PR Review: Revert "Add web frontend for baton-demo database"

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base b157d3c759e5.
Review mode: full
View review run

Review Summary

I scanned the full PR diff for security and correctness issues. This PR cleanly reverts #138. It deletes pkg/browser (the Go server, its tests and web assets), the SDK browser spec doc and the README section. It also puts cmd/baton-demo/main.go back to context.Background() + cmd.Execute() with no browse subcommand, and moves github.com/spf13/cobra back to // indirect in go.mod. Nothing left in the repo references pkg/browser. Cobra is still needed transitively by baton-sdk, and go.sum/vendor/modules.txt still list it. I found no new issues.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant