ComfyUI backport release v0.26.2#14634
Conversation
alexisrolland
requested review from
Kosinkadink,
comfyanonymous,
guill,
kijai and
rattus128
as code owners
📝 WalkthroughWalkthroughSeedance 2.0 nodes add a Mini model option, 4k resolution choices, resolution-aware pricing, and updated polling cost extraction. Grok video now exposes 1080p for grok-imagine-video-1.5 with matching pricing and validation. HappyHorse nodes move to 1.1 variants, expand ratios and reference-image inputs, update pricing, and add image dimension and aspect-ratio checks. Package version files and a dependency pin were bumped. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@comfy_api_nodes/nodes_bytedance.py`:
- Around line 2031-2040: The Seedance 2.0 reference inputs now allow a 4k
resolution, but the validation map for dreamina-seedance-2-0-260128 does not
enforce any pixel limits for that option. Update
SEEDANCE2_REF_VIDEO_PIXEL_LIMITS in comfy_api_nodes/apis/bytedance.py to add a
4k entry for that model, matching the intended 4K pixel range used by the node’s
reference input options. Make sure the model["resolution"] path in the Seedance
validation flow uses this new 4k limit so the pixel range check is applied
consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d0db33b4-f438-4de1-a400-ca17606ccba0
⛔ Files ignored due to path filters (1)
comfy_api_nodes/apis/bytedance.pyis excluded by!comfy_api_nodes/apis/**
📒 Files selected for processing (6)
comfy_api_nodes/nodes_bytedance.pycomfy_api_nodes/nodes_grok.pycomfy_api_nodes/nodes_wan.pycomfyui_version.pypyproject.tomlrequirements.txt
| _seedance2_reference_inputs(["480p", "720p", "1080p", "4k"], default_ratio="adaptive"), | ||
| ), | ||
| IO.DynamicCombo.Option( | ||
| "Seedance 2.0 Fast", | ||
| _seedance2_reference_inputs(["480p", "720p"], default_ratio="adaptive"), | ||
| ), | ||
| IO.DynamicCombo.Option( | ||
| "Seedance 2.0 Mini", | ||
| _seedance2_reference_inputs(["480p", "720p"], default_ratio="adaptive"), | ||
| ), |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Inspect Seedance 2.0 reference-video pixel-limit coverage for newly exposed schema options.
# Expect: SEEDANCE2_REF_VIDEO_PIXEL_LIMITS contains coverage for the Mini model id and for base 4k reference-video resolution.
rg -n -C 6 'SEEDANCE2_REF_VIDEO_PIXEL_LIMITS|dreamina-seedance-2-0-mini|["'\'']4k["'\'']' comfy_api_nodes/nodes_bytedance.pyRepository: Comfy-Org/ComfyUI
Length of output: 8956
🏁 Script executed:
grep -n -A 50 "SEEDANCE2_REF_VIDEO_PIXEL_LIMITS" comfy_api_nodes/apis/bytedance.pyRepository: Comfy-Org/ComfyUI
Length of output: 1484
Add 4k limits to SEEDANCE2_REF_VIDEO_PIXEL_LIMITS.
The Seedance 2.0 node now exposes 4k resolution in reference video inputs (lines 2030-2031), but the validation map SEEDANCE2_REF_VIDEO_PIXEL_LIMITS (in comfy_api_nodes/apis/bytedance.py) lacks a 4k entry for the dreamina-seedance-2-0-260128 model. Currently, selecting 4k will result in a missing limit check, bypassing the intended pixel range validation.
Inspection details
Current map definition in comfy_api_nodes/apis/bytedance.py:
"dreamina-seedance-2-0-260128": {
"480p": {"min": 409_600, "max": 927_408},
"720p": {"min": 409_600, "max": 927_408},
"1080p": {"min": 409_600, "max": 2_073_600},
},
Missing 4k key. Please add the expected pixel range limits (likely ~4K resolution pixels) to ensure model["resolution"] "4k" is properly validated during execution.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@comfy_api_nodes/nodes_bytedance.py` around lines 2031 - 2040, The Seedance
2.0 reference inputs now allow a 4k resolution, but the validation map for
dreamina-seedance-2-0-260128 does not enforce any pixel limits for that option.
Update SEEDANCE2_REF_VIDEO_PIXEL_LIMITS in comfy_api_nodes/apis/bytedance.py to
add a 4k entry for that model, matching the intended 4K pixel range used by the
node’s reference input options. Make sure the model["resolution"] path in the
Seedance validation flow uses this new 4k limit so the pixel range check is
applied consistently.
3 participants
Backport of commits:
API Node PR Checklist
Scope
Pricing & Billing
If Need pricing update:
QA
Comms