Repository navigation
bug/issue 49: Fix findings - #50
Merged
Merged
Conversation
* Replaced reference-equality comparisons with `.equals()`/`Objects.equals()`. * Simplified the redundant `instanceof` check to a null check. * Guarded `@Nullable` field dereferences. * Extracted `DragUtils`'s `dragBoard` splitting into a shared helper function that uses a negative split limit, so an empty trailing field (e.g. an empty dockable identifier with no drop target) is no longer silently dropped. * Added unit test coverage for `DragUtils`'s shared helper function. * Remove disallowed self-closing `<p/>` tags.
* Fix an additional nullability issue.
* update Javadoc configurations remaining from a separate issue.
* Run JavaFX tests headless with Monocle so they pass on CI runners without a display.
Col-E
reviewed
Sep 18, 2026
added 3 commits
September 21, 2026 15:52
* Revert equality comparisons.
* Revert equality comparisons.
philliplbryant
commented
Sep 21, 2026
philliplbryant
changed the title
Col-E
reviewed
Sep 22, 2026
Col-E
reviewed
Sep 22, 2026
* Remove comments notifying readers of intentionally using the equality/inequality operators. * Delete "slop" test class and reduce method visibility. * Delete extraneous AI generated comment.
# Conflicts: # core/src/main/java/software/coley/bentofx/util/DragUtils.java
* Guard the nullable `headers` in `HeaderPane`'s dockables listener and list button, fixing an NPE when a leaf has no header side. * Restore the original `} else if` formatting in `DockableClickBehavior`.
Contributor
Author
|
@Col-E: Are you expecting anything else from me on this PR? |
Owner
|
Nope, just the conflict resolve from before 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instanceofcheck to a null check.@Nullablefield dereferences. InHeaderPane, this fixes an NPE when a leaf with no header side has its dockables changed.DragUtilssplits with a negative limit, so an empty trailing field is kept:extractIdentifierreturns an empty identifier instead ofnull.DockContainerLeaf.toggleCollapsereturns the unchanged state when the parent is null instead of throwing an NPE, with a unit test.coreso JavaFX tests run headless.Other changes have no observable effect on behavior.