Skip to content

Removed trailing comma for PHP 7.1 compatibility #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
selul merged 5 commits into from
Jul 29, 2026
Merged

Removed trailing comma for PHP 7.1 compatibility #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e438144
fix: remove trailing comma for PHP 7.1 compatibility
girishpanchal30 Jul 22, 2026
8be83d3
fix: update PHPUnit job to support multiple PHP and WP versions
girishpanchal30 Jul 22, 2026
c5e408c
fix: remove trailing comma for PHP compatibility
girishpanchal30 Jul 23, 2026
8aea4d3
Merge development into bugfix/526 and resolve workflow conflict
Copilot Jul 29, 2026
ac50c64
ci: set least-privilege token permissions in PHP tests workflow
Copilot Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/test-php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ on:
concurrency:
group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.ref }}
cancel-in-progress: true
permissions:
contents: read
jobs:
phplint:
name: PHP Lint
Expand Down Expand Up @@ -53,8 +55,16 @@ jobs:
run: composer run phpstan

phpunit:
name: PHPUnit
name: PHPUnit (PHP ${{ matrix.php-version }}, WP ${{ matrix.wp-version }})
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
include:
- php-version: '7.2'
wp-version: '6.4'
- php-version: '7.4'
wp-version: 'latest'
services:
mysql:
image: mysql:5.7
Expand All @@ -77,7 +87,7 @@ jobs:
run: sudo apt-get update && sudo apt-get install -y subversion
- name: Install WordPress Test Suite
run: |
bash bin/install-wp-tests.sh wordpress_test root root 127.0.0.1:${{ job.services.mysql.ports['3306'] }}
bash bin/install-wp-tests.sh wordpress_test root root 127.0.0.1:${{ job.services.mysql.ports['3306'] }} ${{ matrix.wp-version }}
Comment on lines 58 to +90

@Soare-Robert-Daniel Soare-Robert-Daniel Jul 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the purpose of this.

- name: Get Composer Cache Directory
id: composer-cache
run: |
Expand Down
10 changes: 5 additions & 5 deletions views/wizard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
__( 'Pick a template to get started.', 'wp-maintenance-mode' ),
tsdk_utmify( 'https://themeisle.com/plugins/otter-blocks/', $this->plugin_slug, 'wizard' ),
__( 'Otter Blocks', 'wp-maintenance-mode' ),
__( 'plugin will be installed and activated to support and customize your layout.', 'wp-maintenance-mode' ),
__( 'plugin will be installed and activated to support and customize your layout.', 'wp-maintenance-mode' )
),
wpmm_translated_string_allowed_html()
);
Expand Down Expand Up @@ -93,9 +93,9 @@
__( 'Templates would have pre-optimized images and all of your website’s images would be delivered via Amazon Cloudfront CDN, resulting in an ≈ 80% increase in speed.', 'wp-maintenance-mode' ),
esc_url( 'https://wordpress.org/plugins/optimole-wp/' ),
'Optimole',
__( 'plugin will be installed and activated.', 'wp-maintenance-mode' ),
__( 'plugin will be installed and activated.', 'wp-maintenance-mode' )
),
wpmm_translated_string_allowed_html(),
wpmm_translated_string_allowed_html()
);
?>
</p>
Expand All @@ -121,9 +121,9 @@
__( 'Speed up your pages by 60-80% with intelligent caching. Achieve faster load times and better search rankings automatically, with', 'wp-maintenance-mode' ),
esc_url( 'https://wordpress.org/plugins/wp-cloudflare-page-cache/' ),
__( 'Super Page Cache', 'wp-maintenance-mode' ),
__( 'plugin installed and activated automatically.', 'wp-maintenance-mode' ),
__( 'plugin installed and activated automatically.', 'wp-maintenance-mode' )
),
wpmm_translated_string_allowed_html(),
wpmm_translated_string_allowed_html()
);
?>
</p>
Expand Down
Loading