Fix wrapper terminal reset for help output#739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the release wrapper terminal cleanup so plain CLI exits like
freebuff --helpand argument errors do not emitESC[?1049l, which can switch buffers and erase visible output.The wrappers now split safe terminal mode cleanup from the full alternate-screen reset, only using the full reset when an interactive child is killed for update or exits by signal.
Applied the same wrapper fix to Freebuff, Codebuff, and staging because they share the same reset logic.
Validated with
node --checkon all three wrappers and a TTY-backed harness confirming help/error output remains visible withoutESC[?1049l.