feat: exclude warmup rounds from perf flamegraph#8
feat: exclude warmup rounds from perf flamegraph#8not-matthias wants to merge 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent warmup-only forks from polluting CodSpeed/perf flamegraphs by marking warmup forks at JVM startup and suppressing benchmark marker emission in those forks.
Changes:
- Add a warmup-fork flag to forked JVM command construction and propagate it via a system property.
- Suppress CodSpeed benchmark marker emission in forked JVMs identified as warmup-only forks.
- Update tests for the changed
getForkedMainCommandsignature and excludenative-*directories from the license plugin.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
jmh-fork/jmh-core/src/test/java/org/openjdk/jmh/runner/RunnerTest.java |
Updates test calls to the new getForkedMainCommand(..., warmupFork) signature. |
jmh-fork/jmh-core/src/main/java/org/openjdk/jmh/runner/Runner.java |
Passes warmupFork to fork command builder and adds -Dio.codspeed.warmupFork=true for warmup forks. |
jmh-fork/jmh-core/src/main/java/org/openjdk/jmh/runner/BaseRunner.java |
Introduces warmup-fork detection and attempts to add benchmark start/end markers for measurement iterations (suppressed for warmup forks). |
jmh-fork/jmh-core/pom.xml |
Excludes native-*/** from the license formatting/check plugin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… skip warmup forks
… lib is unavailable
0411853 to
ff83f3b
Compare
Merging this PR will degrade performance by 20.31%
Performance Changes
Comparing Footnotes
|
No description provided.