Attempt at making RootSolvers.jl compatible with Reactant - #99
Open
olivierbonte wants to merge 8 commits into
Open
Attempt at making RootSolvers.jl compatible with Reactant#99olivierbonte wants to merge 8 commits into
olivierbonte wants to merge 8 commits into
Conversation
olivierbonte
changed the title
olivierbonte
marked this pull request as ready for review
August 11, 2026 14:24
olivierbonte
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Terrarium.jl uses RootSolvers.jl to solve the surface energy balance equation. Currently, there is an ongoing effort (see NumericalEarth/Terrarium.jl#157) to make the model compatible with Reactant.jl.
This PR is an attempt at making RootSolvers.jl compatible with Reactant.jl. It focusses on allowing forward evaluation of the solvers. Compatibility with AD tools such as Enzyme on top of Reactant.jl are not yet in this PR.
Changes are added in a way to minimally change the current algorithms. Change for loops to while loops was sometimes necessary to allow for the correct tracing, but this does not alter the algorithms.
Furthermore, all test are passing locally (WSL), both for CuArray as the regular tests.