fix: file-index error count, reranker toast label, script and doc typos - #856
Open
simpleqt wants to merge 1 commit into
Open
fix: file-index error count, reranker toast label, script and doc typos#856simpleqt wants to merge 1 commit into
simpleqt wants to merge 1 commit into
Conversation
- index/file/ui.py: after unpacking 'results, index_errors, docs', n_errors counted the stale pre-flight 'errors' list (guaranteed empty because of the early return), so 'Have errors for N files' never fired when files actually failed to index; count index_errors instead - rerankings/ui.py: connection-test toast said 'Embedding ... connect successfully' (copied from embeddings/ui.py); now names the reranker - scripts/run_linux.sh: echoed $miniconda_url before assigning it; swap the lines to match run_macos.sh - docs customize-flows.md: malformed '"component: "dropdown",' dict entry (SyntaxError when copied) and 'from ktem.embeddings.manager import embeddings' (module only exports embedding_models_manager) - README.md: 'flowssettings' -> flowsettings - 'in in' doubled word in five NotImplementedError messages; 'Can not found model' -> 'Cannot find model' in three UI files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Functional fixes
libs/ktem/ktem/index/file/ui.py: after unpackingresults, index_errors, docs,n_errorscounted the stale pre-flighterrorslist — which is guaranteed empty at that point (the function returns earlyif errors:) — so theHave errors for N fileswarning never fired even when files failed to index. Now countsindex_errors.rerankings/ui.py: the connection-test toast said "Embedding … connect successfully" (copy-pasted fromembeddings/ui.py); now says "Reranking model …".scripts/run_linux.sh: echoed$miniconda_urlbefore assigning it (printed an empty URL); swapped the lines to matchrun_macos.sh.Docs
docs/pages/app/customize-flows.md: malformed"component: "dropdown",dict entry (SyntaxError if copied) →"component": "dropdown",;from ktem.embeddings.manager import embeddings→import embedding_models_manager as embeddings(the module exports onlyembedding_models_manager).README.md:flowssettings→flowsettings.Minor
NotImplementedErrormessages;Can not found model→Cannot find modelin three parallel UI files.