Drop the quote wrapper for INTERNED_GENERATOR

[richardkiss]

[agent draft — I haven't reviewed this text yet]

Follow-up to #1511.

• Drops the (q . ...) quote wrapper from the interned/serde_2026 generator format. Since the block is never executed under this flag, wrapping it in a quote (whose only purpose is to make run_program return its argument unchanged) served no purpose and cost 20 gas for nothing.
• run_block_generator2, get_coinspends_for_trusted_block(_with_conditions), additions_and_removals, and get_puzzle_and_solution_for_coin2 now parse the interned spend list directly instead of calling run_program on it.
• Pre-HF2 quoted formats (solution_generator, solution_generator_backrefs) are unchanged.

All existing tests updated; new tests cover the unquoted round-trip and the no-execution parse path for INTERNED_GENERATOR across all four consumers.

---

Note

High Risk
Changes consensus block generator encoding and validation under INTERNED_GENERATOR across builder, cost, and multiple parse paths; incorrect rollout would fork the network at HF2.

Overview
Removes the (q . ...) quote wrapper from the post–hard-fork serde_2026 / INTERNED_GENERATOR block generator. The on-chain blob is now a wrapped spend list ((spends...)), not a runnable quoted program, which drops useless quote execution cost and shrinks wrapper vbyte accounting (WRAPPER_VBYTES 11→5, empty builder block_cost 0).

build_generator(..., quote) keeps quoted output for solution_generator / solution_generator_backrefs; solution_generator_2026, InternedBlockBuilder::finalize, and interned base-cost in spendbundle_conditions emit the unquoted tree.

With INTERNED_GENERATOR, run_block_generator2, trusted coinspend helpers, and additions_and_removals decode the spend list directly (via first) instead of run_program on the generator; quote/node shape checks are skipped on that path. Invalid non–spend-list serde_2026 blobs now fail at spend parsing (InvalidCondition) rather than ComplexGeneratorReceived. Tests were updated for the new encoding and hashing (classic reference still quoted for pre-fork comparisons).

^{Reviewed by Cursor Bugbot for commit cf49946. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Stale Bugbot comment from a previous run.

[coveralls-official]

Coverage Report for CI Build 36228906768

Coverage increased (+0.07%) to 82.502%

Details

• Coverage increased (+0.07%) from the base build.
• Patch coverage: 7 uncovered changes across 3 files (192 of 199 lines covered, 96.48%).
• 1 coverage regression across 1 file.

Uncovered Changes

File	Changed	Covered	%
crates/chia-consensus/src/build_interned_block/additional_tests.rs	20	17	85.0%
crates/chia-consensus/src/run_block_generator.rs	113	110	97.35%
crates/chia-consensus/src/additions_and_removals.rs	40	39	97.5%
Total (8 files)	199	192	96.48%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File	Lines Losing Coverage	Coverage
wheel/src/api.rs	1	84.81%

---

Coverage Stats

Relevant Lines:	20448
Covered Lines:	16870
Line Coverage:	82.5%
Coverage Strength:	11350794.89 hits per line

---

💛 - Coveralls

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit cf49946. Configure here.}

[cursor]

Interned puzzle lookup still executes

High Severity

get_puzzle_and_solution_for_coin2 still runs the interned generator through run_program after solution_generator_2026 and InternedBlockBuilder dropped the (q . ...) wrapper. That tree is now a spend list, not an executable quote, so puzzle and solution lookup fails for every INTERNED_GENERATOR / serde_2026 block.

 

^{Reviewed by Cursor Bugbot for commit cf49946. Configure here.}