Skip to content

Hungyuehc/omniml 5029 - #2

Open
hychiang-git wants to merge 310 commits into
ChenhanYu:mainfrom
hychiang-git:hungyuehc/omniml-5029
Open

Hungyuehc/omniml 5029#2
hychiang-git wants to merge 310 commits into
ChenhanYu:mainfrom
hychiang-git:hungyuehc/omniml-5029

Conversation

@hychiang-git

Copy link
Copy Markdown

This is the patch for OMNIML-5029.
Please merge #1 first where we sync the ChanhanYu to the upstream NVIDIA's branch.

Phlip79 and others added 30 commits April 23, 2026 04:27
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
NVIDIA#4403)

Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
Co-authored-by: Philip Petrakian <ppetrakian@nvidia.com>
…IA#4227)

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
…4301)

Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ss curve gaps for latent MoE models (NVIDIA#4433)

Signed-off-by: root <jiemingz@nvidia.com>
…VIDIA#4158)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…VIDIA#4422)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: rprenger <rprenger@nvidia.com>
Signed-off-by: qiyuw <qiyuw@nvidia.com>
Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Co-authored-by: root <root@eos0047.eos.clusters.nvidia.com>
Co-authored-by: root <root@eos0260.eos.clusters.nvidia.com>
Co-authored-by: Dennis(Zhenhuan) Liu <denliu@nvidia.com>
… (NMFW-17) (NVIDIA#4368)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…VIDIA#4330)

Co-authored-by: mhh111 <mahonghao1@huawei.com>
Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
…ing (NVIDIA#4276)

Co-authored-by: Hanpeng Hu <haaanpeng@outlook.com>
Co-authored-by: Deepak Narayanan <deepakn94@gmail.com>
Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
ko3n1g and others added 30 commits May 26, 2026 17:23
…h tests (NVIDIA#4986)

Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Robin Zhang <robinz@nvidia.com>
Co-authored-by: Dennis Liu <denliu@nvidia.com>
Co-authored-by: Philip Petrakian <ppetrakian@nvidia.com>
Co-authored-by: Shifang Xu <shifangx@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
…port full-iteration (FWD-BWD) CUDA graphability. (NVIDIA#4663)

Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
…VIDIA#5022)

Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
)

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
…VIDIA#4881)

Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
NVIDIA#5045)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…sion__

is_nvrx_min_version() unconditionally reads nvrx.__version__, but older
nvidia_resiliency_ext builds (notably the one bundled in the NeMo
25.11.nemotron_3_nano container image) don't expose that attribute. The
result is an AttributeError at pytest collection time for any test that
imports megatron.core.dist_checkpointing, well before the test logic
even runs.

Switch the read to getattr(nvrx, '__version__', '0.0.0') so the
fallback path is reached without crashing. Behavior for builds that DO
expose __version__ is unchanged.

Encountered in OMNIML-5029 when bind-mounting our packaged Megatron-LM
over the container's older one to enable test_moe_sharded_state_dict.

Signed-off-by: Hung-Yueh Chiang <hungyuehc@nvidia.com>
…rting

has_nvrx_async_support() asserts is_nvrx_min_version() is True, which
crashes the entire dist_checkpointing import chain when the installed
nvidia-resiliency-ext is older than the 0.6.0 floor — or, more subtly,
when it lacks __version__ entirely (the case on nemo:25.11.nemotron_3_nano,
where is_nvrx_min_version() conservatively returns "0.0.0").

Replace the assert with an early `return False` so the function obeys
its own contract ("returns whether NVRx async checkpointing is usable")
without crashing. The caller already has a non-async fallback path; it
just needs to be told that async isn't available.

Pairs with the earlier getattr(nvrx, '__version__', '0.0.0') guard so
the import succeeds even when the attribute is missing, and the
downstream version-floor check becomes recoverable instead of fatal.

Signed-off-by: Hung-Yueh Chiang <hungyuehc@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.