Hungyuehc/omniml 5029 - #2
Open
hychiang-git wants to merge 310 commits into
Open
Conversation
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
NVIDIA#4403) Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
Co-authored-by: Philip Petrakian <ppetrakian@nvidia.com>
…IA#4227) Signed-off-by: Maanu Grover <maanug@nvidia.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
…4301) Co-authored-by: Siddharth Singh <sidsingh@nvidia.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…nference cuda graph scope for hybrid models (NVIDIA#4440)
…ss curve gaps for latent MoE models (NVIDIA#4433) Signed-off-by: root <jiemingz@nvidia.com>
…VIDIA#4158) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…VIDIA#4422) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: rprenger <rprenger@nvidia.com>
Signed-off-by: qiyuw <qiyuw@nvidia.com> Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
…VIDIA#4427) Signed-off-by: Cory Ye <cye@nvidia.com>
Co-authored-by: root <root@eos0047.eos.clusters.nvidia.com> Co-authored-by: root <root@eos0260.eos.clusters.nvidia.com> Co-authored-by: Dennis(Zhenhuan) Liu <denliu@nvidia.com>
… (NMFW-17) (NVIDIA#4368) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…VIDIA#4330) Co-authored-by: mhh111 <mahonghao1@huawei.com> Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
…ing (NVIDIA#4276) Co-authored-by: Hanpeng Hu <haaanpeng@outlook.com> Co-authored-by: Deepak Narayanan <deepakn94@gmail.com> Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
…h tests (NVIDIA#4986) Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Robin Zhang <robinz@nvidia.com> Co-authored-by: Dennis Liu <denliu@nvidia.com> Co-authored-by: Philip Petrakian <ppetrakian@nvidia.com> Co-authored-by: Shifang Xu <shifangx@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
…port full-iteration (FWD-BWD) CUDA graphability. (NVIDIA#4663) Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
…VIDIA#5022) Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…A#5023) Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
…VIDIA#4881) Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
…VIDIA#5040) Signed-off-by: oliver könig <okoenig@nvidia.com>
…DIA#4938) Signed-off-by: Li Ding <liding@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
NVIDIA#5045) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…sion__ is_nvrx_min_version() unconditionally reads nvrx.__version__, but older nvidia_resiliency_ext builds (notably the one bundled in the NeMo 25.11.nemotron_3_nano container image) don't expose that attribute. The result is an AttributeError at pytest collection time for any test that imports megatron.core.dist_checkpointing, well before the test logic even runs. Switch the read to getattr(nvrx, '__version__', '0.0.0') so the fallback path is reached without crashing. Behavior for builds that DO expose __version__ is unchanged. Encountered in OMNIML-5029 when bind-mounting our packaged Megatron-LM over the container's older one to enable test_moe_sharded_state_dict. Signed-off-by: Hung-Yueh Chiang <hungyuehc@nvidia.com>
…rting
has_nvrx_async_support() asserts is_nvrx_min_version() is True, which
crashes the entire dist_checkpointing import chain when the installed
nvidia-resiliency-ext is older than the 0.6.0 floor — or, more subtly,
when it lacks __version__ entirely (the case on nemo:25.11.nemotron_3_nano,
where is_nvrx_min_version() conservatively returns "0.0.0").
Replace the assert with an early `return False` so the function obeys
its own contract ("returns whether NVRx async checkpointing is usable")
without crashing. The caller already has a non-async fallback path; it
just needs to be told that async isn't available.
Pairs with the earlier getattr(nvrx, '__version__', '0.0.0') guard so
the import succeeds even when the attribute is missing, and the
downstream version-floor check becomes recoverable instead of fatal.
Signed-off-by: Hung-Yueh Chiang <hungyuehc@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the patch for OMNIML-5029.
Please merge #1 first where we sync the ChanhanYu to the upstream NVIDIA's branch.