fix(copilot): respect widget theme for logo URL - #2981
Open
axelray-dev wants to merge 2 commits into
Open
Conversation
Fixes Chainlit#2976 Co-Authored-By: Codex <codex@openai.com>
axelray-dev
marked this pull request as ready for review
July 14, 2026 08:40
axelray-dev
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
July 14, 2026 08:40
Collaborator
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the Copilot widget, the logo URL was following the OS color scheme instead of the widget theme (mount config or
vite-ui-themein localStorage).Root cause: Header renders the shared frontend
Logo, which reads the frontendThemeProvidercontext. That provider is not mounted in the copilot tree, so the logo fell back tosystem/prefers-color-scheme.Changes
themeVariantprop onfrontend/src/components/Logo.tsx. When set, it is used forgetLogoEndpoint; otherwise existinguseTheme()behavior is unchanged for the main app.useTheme().variantfromlibs/copilot/src/components/Header.tsxintoLogo.themeVariant="light"and asserts the logo endpoint is called withlight.Verification
pnpmVitest forfrontend/tests/Logo.spec.tsxFixes #2976
Summary by cubic
Fixes the Copilot widget logo so it follows the widget theme (mount config or
vite-ui-theme) instead of the OS color scheme, ensuring the correct light/dark logo URL.themeVariantprop onLogo; default behavior unchanged.Header, passuseTheme().variantintoLogosogetLogoEndpointuses the widget theme.themeVariant="light"triggersgetLogoEndpoint('light', ...).Written for commit 41e7fd2. Summary will update on new commits.