Honor dependent associations during STI teardown - #65
Merged
Conversation
nertzy
force-pushed
the
honor-sti-dependent-destruction
branch
7 times, most recently
from
August 7, 2026 19:55
5eac8b4 to
a155f6c
Compare
Destroy temporary STI rows through Active Record so callbacks and dependent associations run during teardown. Raise when destruction is aborted instead of silently leaving an unloadable row. Fixes #64
nertzy
force-pushed
the
honor-sti-dependent-destruction
branch
from
August 7, 2026 20:00
a155f6c to
5dd59b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
table(false)STI rows through Active Record so callbacks and dependent associations run during teardownActiveRecord::RecordNotDestroyedwhen a callback aborts cleanup rather than silently leaving an unloadable STI rowdependent: :destroyrecords and aborted destructionCloses #64
Test plan
delete_allteardowndestroy_allmise x -- bin/rake(132 RSpec examples; 10 minitest runs; StandardRB)