Proper Boost version handling - #1049
Open
Bjoe wants to merge 4 commits into
Open
Conversation
Contributor
|
Due to the new ICTS rules (#1036), for the moment we will not accept any new PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got the issue that VSOMEIP_BOOST_VERSION was not proper set via cmake.
The settings of VSOMEIP_BOOST_VERSION are depended which find_package() approach is used. Config or module. And also who builds/generate the BoostConfig.cmake (cmake-package) or FindBoost.cmake. In a conan environment this might be automatically generated.
It's much more stable and cleaner to use the version from the provide boost/version.hpp header file. Even in the different boost libraries, boost/version.hpp is used.