Open
Conversation
…mised axes for rotation at residue level are introduced
…ed as center rather than average position of atoms
Member
|
Good work on getting the custom bonded axes to work for the residues! Before it can be accepted, the tests will need fixing so that the CI passes. If you need help with the tests, please email me and we can arrange a meeting. |
Collaborator
Author
|
@skfegan Thank you! I think that would be good as I didn't want to change anything for the tests on my own. I will send you an email. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issues #26 and #279 and introduces custom axes for residue level rotations/UA level translations.
Changes
DataContainer at the residue level now consists of the residue of interest alongside its neighbours. The residue_group data container contains two residues for the first and last residue (residue + the one neighbours), or three residues otherwise (residue + 2 neighbours).
Translation axes at UA level for molecules with multiple residues, are calculated the same way as residue level rotation axes.
New function get_chain in axes.py that identifies the shortest heavy-atom path between two heavy atoms in a given residue. This is used to define the backbone of a residue as the shortest path between heavy atoms bonded to neighbouring residues. For the first residue, it uses the first atom in the residue as the starting point, and for the last residue, it uses the last heavy atom with only one bond to another heavy atom as the ending point.
For a protein, it finds the N,CA,C atoms. (+ O in the case of the last residue.)
For a DNA molecule, it finds the chain shown in purple.
New function get_custom_residue_moment_of_inertia to calculate residue MOI in the coordinate frame of the custom rotation axes.
New function get_residue_custom_axes which computes the coordinate frame for a residue based on the two edge atoms (heavy atoms linearly bonded to neighbouring atoms) and centre.
Impact