Repository navigation
fix(desktop): paste screenshots and deliver image attachments to the model - #234
Merged
VickyXAI merged 2 commits intoNov 3, 2026
Merged
Conversation
stripLargeImageData only handled images nested in tool_result, so a pasted or picked image (top level of the user message) was written to the session jsonl in full on every attach. Strip it above the same 50 KB threshold; the in-memory turn keeps the bytes, and the placeholder tells the model to ask for a re-attach on resume.
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
Desktop beta.9 ignores screenshot paste, and even images added through the existing file picker are dropped by
agent.sendbefore reaching the agent. Users can now paste a screenshot with Cmd+V / Ctrl+V, preview or remove it, and send it to the model, including an image-only message. Ordinary text paste remains unchanged.Implementation
/retry, recognize vision input during routing, and use a default prompt for image-only messages.Validation
ORBIT-970862and correctly identified the blue rectangle and red circle./retry, ordinary follow-up text, and rejection before model invocation. These automated fixture tests are separate from the paid native verification above.Independent of #233 and based directly on the current Desktop beta.9 release branch. This PR does not publish an installer.