RevitMechanicalSpecificationHelpersUpdate: Вспомогательные процессы - #489
Open
Redomine wants to merge 5 commits into
Open
RevitMechanicalSpecificationHelpersUpdate: Вспомогательные процессы #489Redomine wants to merge 5 commits into
Redomine wants to merge 5 commits into
Conversation
Отредактированы сценарии при которых занятый элемент попадал в обработку
…соре, чтобы избежать ситуаций когда семейство вложенное и его параметры ADSK_ блокируются
… повернутость и пересоздание в случае не прохождения.
dosymep
requested changes
Aug 24, 2026
dosymep
left a comment
dosymep
left a comment
Member
There was a problem hiding this comment.
- обнови форматирование кода, у тебя нет использования нового C#
Comment on lines
+16
to
+26
| switch(parameter.StorageType) { | ||
| case StorageType.Integer: | ||
| return new ElementParameterValue(parameter.Id, parameter.StorageType, parameter.AsInteger()); | ||
| case StorageType.Double: | ||
| return new ElementParameterValue(parameter.Id, parameter.StorageType, parameter.AsDouble()); | ||
| case StorageType.String: | ||
| return new ElementParameterValue(parameter.Id, parameter.StorageType, parameter.AsString()); | ||
| case StorageType.ElementId: | ||
| return new ElementParameterValue(parameter.Id, parameter.StorageType, parameter.AsElementId()); | ||
| default: | ||
| return null; |
| } | ||
| } | ||
|
|
||
| public void TryApply(Parameter parameter) { |
Member
There was a problem hiding this comment.
я бы добавил проверку соответствия StorageType у параметра и сохраненного значения
Member
There was a problem hiding this comment.
чтобы во время исключения было понятно какая ошибка и где, а то тут будет InvalidCastException без контекста
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2)Изменён пайплайн MaskReplacer: результаты имени и марки передаются через SpecificationElement. Это необходимо для обработки вложений - параметры ADSK у таких элементов блокируются, не позволяя использование масок.