fix: generate catalog when user configures context window (#1594) - #1786
Open
dongyu23 wants to merge 1 commit into
Open
fix: generate catalog when user configures context window (#1594)#1786dongyu23 wants to merge 1 commit into
dongyu23 wants to merge 1 commit into
Conversation
…#1594) PR BigPizzaV3#1722 fixed the early return in apply_model_catalog_to_config that silently dropped the Manager's context window for suffixless custom models. Codex then fell back to its bundled 272000 default and the CLI showed ~258K instead of the configured value. The fix moves the fallback parse before the early return and adds fallback.is_none() to the guard, so a user-configured context window forces catalog generation. Two integration tests failed because they set context_window=200000 while asserting no catalog generation. Both tests now omit context_window and auto_compact_limit, preserving their original intent: no catalog when nothing is customized. Closes BigPizzaV3#1722 References BigPizzaV3#1594
dongyu23
force-pushed
the
fix/1722-catalog-context-window-tests
branch
from
August 5, 2026 17:15
0b9de69 to
91254e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes PR #1722 by fixing the two failing integration tests.
PR #1722 fixed the early return in
apply_model_catalog_to_configthat silently dropped the Manager's context window for suffixless custom models. Without the fix, Codex fell back to its bundled 272000 default and the CLI showed ~258K instead of the configured value (#1594).The fix moves the
fallbackparse before the early return and addsfallback.is_none()to the guard, so a user-configured context window forces catalog generation.Test fixes
Two integration tests failed because they set
context_window=200000while asserting no catalog generation. With the fix, configuring a context window now correctly triggers generation.apply_relay_profile_does_not_write_model_catalog_json_for_selected_models: removedcontext_window/auto_compact_limit, preserving the original intent — no catalog when nothing is customized.apply_relay_profile_no_catalog_when_model_list_has_no_suffix→ renamed toapply_relay_profile_generates_catalog_when_context_window_configured: now tests the positive case —context_windowset, no suffix → catalog IS generated with the correct window value in bothconfig.tomland the catalog JSON.Verification
Closes #1722
References #1594