fix(vscode): Fix VS Code extension CFS npm install - #9522
Merged
Brian Lam (lambrianmsft) merged 1 commit intoAug 11, 2026
Merged
Conversation
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No change needed |
| Commit Type | ✅ | No change needed |
| Risk Level | ✅ | Keep Medium (matches advised estimate) |
| What & Why | ✅ | No change needed |
| Impact of Change | ✅ | No change needed |
| Test Plan | ✅ | Manual testing justified for build tooling |
| Contributors | Credit contributors if any | |
| Screenshots/Videos | ✅ | Not applicable |
All required checks pass. This PR is compliant and ready to merge. 🎉
Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Tue, 11 Aug 2026 02:39:35 GMT
Contributor
There was a problem hiding this comment.
Pull request overview
Routes VS Code extension dependency installation through the authenticated CFS npm configuration and resolves Node.js warning-flow type errors.
Changes:
- Adds a helper for installing
distdependencies withNPM_CONFIG_USERCONFIG. - Updates extension build and packaging scripts to use the helper.
- Refactors Node.js warning handling and telemetry formatting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
validateNodeJsIsLatest.ts |
Adjusts telemetry values and warning handling. |
install-dist-dependencies.js |
Adds authenticated nested npm installation. |
package.json |
Uses the new installation helper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Krrish Mittal (takyyon)
approved these changes
Aug 11, 2026
Brian Lam (lambrianmsft)
enabled auto-merge (squash)
August 11, 2026 02:12
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Brian Lam (lambrianmsft)
force-pushed
the
lambrian-microsoft-pipeline-cfs-network-isolation
branch
from
August 11, 2026 02:25
dd7a0de to
e9d56c1
Compare
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Follow-up to the CFS npm registry migration for SR21 / 1ES Network Isolation. The root pnpm install uses the authenticated CFS npmrc, but the VS Code extension build runs a nested
npm installfromapps/vs-code-designer/dist. This change routes that nested install through a helper that passes--userconfigfromNPM_CONFIG_USERCONFIGwhen the pipeline provides the authenticated npmrc, avoiding fallback to unauthenticated/public npm during CFSClean builds.Impact of Change
scripts/install-dist-dependencies.jsinstead of inlinecd dist && npm install.Test Plan
pnpm exec biome check --write apps\vs-code-designer\scripts\install-dist-dependencies.js apps\vs-code-designer\package.json; helper simulation with temporary non-secretNPM_CONFIG_USERCONFIG;pnpm --filter vscode-designer build:extensionreached and completed nested npm install. The build still logs pre-existing unrelated typecheck diagnostics, includingvalidateNodeJsIsLatest.ts, but exits successfully.Contributors
N/A
Screenshots/Videos
N/A