Skip to content

fix(vscode): Fix invalid workflow-designtime artifacts path with symlink - #9501

Merged
Andrew Eldridge (andrew-eldridge) merged 4 commits into
mainfrom
aeldridge/vscode-local-artifacts-fix
Aug 10, 2026
Merged

fix(vscode): Fix invalid workflow-designtime artifacts path with symlink#9501
Andrew Eldridge (andrew-eldridge) merged 4 commits into
mainfrom
aeldridge/vscode-local-artifacts-fix

Conversation

@andrew-eldridge

@andrew-eldridge Andrew Eldridge (andrew-eldridge) commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Adds symlink from projectRoot/workflow-designtime/Artifacts to projectRoot/Artifacts in design-time file consistency check to fix issue where design-time api checks for Artifacts in cwd (i.e. workflow-designtime) for dynamic list on some operations. Closes #9214

Impact of Change

  • Users: Fixes dynamic list issue in designer where artifacts don't load due to incorrect path
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

Andrew Eldridge (@andrew-eldridge)

@andrew-eldridge Andrew Eldridge (andrew-eldridge) added VSCode Issues or PRs specific to VS Code extension risk:low Low risk change with minimal impact labels Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Fix invalid workflow-designtime artifacts path with symlink
  • Issue: None — uses a valid fix: prefix with a (vscode) scope and is descriptive.
  • Recommendation: No change needed.

Commit Type

  • fix - Bug fix is selected (exactly one).
  • Note: Correctly matches the title prefix and the nature of the change (fixing the design-time Artifacts path).

Risk Level

  • Medium is selected in the body and the risk:medium label is present — they match. This also matches my advised estimate: the change modifies extension distribution code (apps/vs-code-designer) and adds filesystem symlink/junction logic, which is moderate user-impacting runtime behavior. Medium is correct.

What & Why


Impact of Change

  • All three audiences are addressed (Users specified; Developers and System marked N/A, which is acceptable).
  • Recommendation:
    • Users: Good — describes the dynamic-list artifacts fix.
    • Developers: N/A is fine here.
    • System: Optionally note the new filesystem junction behavior in the design-time directory, but not required.

Test Plan

  • Unit tests added/updated is checked and confirmed in the diff (projectFilesConsistency.test.ts adds an artifacts junction suite covering create/skip/recreate/warn cases). Satisfies CHECK TESTS.

Contributors

  • @andrew-eldridge is credited. Consider crediting any PM/designer involved if applicable.

⚠️ Screenshots/Videos

  • Not required — the diff touches apps/vs-code-designer/src (extension host logic + tests), not libs/designer-ui/src, libs/designer/src, or apps/vs-code-react UI components. No visual change detected.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type No change needed
Risk Level Medium is correct
What & Why No change needed
Impact of Change Optional: note junction behavior
Test Plan Unit tests confirmed
Contributors Optional: credit PM/designer
Screenshots/Videos ⚠️ Not required (non-visual)

All required checks pass — this PR is compliant and cleared to merge. Nice work including targeted unit tests for the junction logic.


Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Mon, 10 Aug 2026 15:47:57 GMT

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Check

🎉 All changed files have adequate test coverage!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Artifacts junction for the VS Code design-time host so dynamic operations can access project artifacts.

Changes:

  • Creates or repairs the design-time Artifacts junction.
  • Adds focused junction lifecycle and failure tests.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
projectFilesConsistency.ts Ensures the design-time Artifacts junction exists.
projectFilesConsistency.test.ts Tests junction creation, repair, and failure handling.

@andrew-eldridge
Andrew Eldridge (andrew-eldridge) merged commit 6c2be79 into main Aug 10, 2026
39 of 41 checks passed
@andrew-eldridge
Andrew Eldridge (andrew-eldridge) deleted the aeldridge/vscode-local-artifacts-fix branch August 10, 2026 16:56
Brian Lam (lambrianmsft) pushed a commit that referenced this pull request Aug 12, 2026
* Revert "fix(vscode): Fix invalid workflow-designtime artifacts path with symlink (#9501)"

This reverts commit 6c2be79.

* fix function signature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:medium Medium risk change with potential impact VSCode Issues or PRs specific to VS Code extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workflow-designtime used when accessing local artifacts from VSCode

3 participants