Repository navigation
fix(annotate): arrow geometry, label placement, initial pointer visibility - #2554
Merged
Merged
Conversation
…ighbours, hide the pointer until first move (#2553)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2553.
directionand ends at the target's nearest edge (or corner for diagonal directions). The start sits 56px off that edge on thedirectionside, and the shaft and head are drawn along the vector. This replaces the fixed curve plus coarse CSS rotation, which landed beside the target and pointed the wrong way forleft/right.visibility: hiddenand appears on the firstmousemove, so it no longer sits at (0,0) before the first interaction.Tests
npm run buildclean.browser-annotations.browser.test.ts3/3: new assertions that the arrow tip lands at the target edge for a direction, and that a label doesn't intersect the target's sibling when there's roombrowser-actions-presentation.browser.test.ts1/1: the pointer is hidden before the first movetest:browser-video-capture4/4,browser-preview-routing16/16Drafted by a Homeboy cook (
cook-detached-29911708). Its gates passed, but publication stalled (promotion_operation: operation_in_progress). With Chris's authorization, it was re-verified and published outside Homeboy.AI-assisted: drafted by an OpenCode agent, reviewed and finalized by Extra Chill Bot.