Skip to content

fix(ui): adding name of robot on right click SYNTH-271 - #1439

Merged
BrandonPacewic merged 4 commits into
devfrom
darora1/271/robot-names
Jul 29, 2026
Merged

fix(ui): adding name of robot on right click SYNTH-271#1439
BrandonPacewic merged 4 commits into
devfrom
darora1/271/robot-names

Conversation

@Dhruv-0-Arora

Copy link
Copy Markdown
Collaborator

SYNTH-271

Task

Right clicking a robot would title it "A Robot"
Fields would say "A Field"

Solution

Replace "A Robot" with the scheme name (Ernie <- no brackets [])
Replace "A Field" with "Field"

Screenshot 2026-07-22 at 10 41 57 AM

Verification

Check whether spawned robots have their scheme name.

Breaking change

in this new function:

    public get schemeName() {
        return this.multiplayerOwnerName ?? (this.brain as SynthesisBrain)?.inputSchemeName
    }

if a robot is not configured, it will pass back "Not Configured" instead of undefined so in the configure assets panel, it will replace [-] ... with[Not Configured] ...

The purpose of this change was to avoid


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

Signed-off-by: Dhruv Arora <dhruv.arora1@autodesk.com>
Signed-off-by: Dhruv Arora <dhruv.arora1@autodesk.com>
@Dhruv-0-Arora Dhruv-0-Arora self-assigned this Jul 23, 2026
@Dhruv-0-Arora
Dhruv-0-Arora requested review from a team as code owners July 23, 2026 00:23

@AlexD717 AlexD717 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a bit more explanation about why we are going with this name format instead of the already established descriptiveName?

Comment thread fission/src/mirabuf/MirabufSceneObject.ts Outdated
Comment thread fission/src/mirabuf/MirabufSceneObject.ts Outdated
@Dhruv-0-Arora
Dhruv-0-Arora requested a review from AlexD717 July 24, 2026 20:15
Signed-off-by: Dhruv Arora <dhruv.arora1@autodesk.com>

@AlexD717 AlexD717 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lotm

@PepperLola PepperLola added the ui/ux Relating to user interface, or in general, user experience label Jul 24, 2026
@Dhruv-0-Arora
Dhruv-0-Arora requested a review from rutmanz July 25, 2026 02:00
@BrandonPacewic
BrandonPacewic enabled auto-merge July 29, 2026 19:32
@BrandonPacewic
BrandonPacewic merged commit f7dbd99 into dev Jul 29, 2026
17 checks passed
@BrandonPacewic
BrandonPacewic deleted the darora1/271/robot-names branch July 29, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui/ux Relating to user interface, or in general, user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants