Improve state management [SYNTH-263] - #1433
Merged
Merged
Conversation
0xda157
force-pushed
the
dionkud/do-not-mutate-react
branch
from
July 22, 2026 17:13
7da54be to
5134e57
Compare
0xda157
force-pushed
the
dionkud/do-not-mutate-react
branch
from
July 22, 2026 20:55
870aaf6 to
bea3dff
Compare
azaleacolburn
approved these changes
Jul 23, 2026
Dhruv-0-Arora
requested changes
Jul 24, 2026
0xda157
force-pushed
the
dionkud/do-not-mutate-react
branch
from
July 24, 2026 18:10
8f8052e to
68c28c7
Compare
PepperLola
added
ui/ux
…ot-mutate-react # Conflicts: # fission/src/ui/panels/configuring/assembly-config/interfaces/SequentialBehaviorsInterface.tsx
Dhruv-0-Arora
approved these changes
Aug 4, 2026
BrandonPacewic
approved these changes
Aug 4, 2026
| onClick={checked => { | ||
| writePreference("RenderScoreboard", checked) | ||
| if (checked) { | ||
| // TODO: figure out scoreboard - I think it should be its own component and not a panel |
Member
There was a problem hiding this comment.
Should purge all the TODOs from this codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
SYNTH-263
Symptom
many of our components include
useReducers purely to avoid manage state in the correct react waySolution
this pr improve the state handling in many locations, primarily by copying the state using their
setfunction instead of directly mutating them.Note
There are few more places with very poor state management, but I've deemed them too difficult to improve in this pr. Ideally they will be addressed later.
Verification
Playwright tests pass, and the UI seems to work as expected.
Before merging, ensure the following criteria are met: