Skip to content

Improve Vite HMR [SYNTH-231] - #1427

Merged
PepperLola merged 6 commits into
devfrom
zachr/231/vite-hmr
Jul 22, 2026
Merged

Improve Vite HMR [SYNTH-231]#1427
PepperLola merged 6 commits into
devfrom
zachr/231/vite-hmr

Conversation

@rutmanz

@rutmanz rutmanz commented Jul 20, 2026

Copy link
Copy Markdown
Member

Task

SYNTH-231

Symptom

Often when developing and changing UI features, the whole screen goes white or reloads. This is obnoxious and makes UI development slow and tedious

Solution

Fixed the exporting issues that were breaking HMR, as well as restructuring World to be a singleton instead of a fully static class and ScoreTracker to be a system of World

Verification

You can edit UI elements with robots spawned and panels open and have nothing bad happen but changes appear.

Note that not all things continue to work seamlessly. For example, spawning robots before and after is a little suspicious. This PR is not attempting to solve that, the purpose of this change is to improve the developer experience of editing UI elements.

If you are able experience crashing / white screening, however, please do let me know


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@rutmanz
rutmanz requested review from a team as code owners July 20, 2026 19:28
@rutmanz rutmanz self-assigned this Jul 20, 2026
@rutmanz rutmanz added the development Related to the development process (workflows, dev-facing improvements, etc.) label Jul 20, 2026

@AlexD717 AlexD717 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried editing a few panels and they all successfully hot reloaded. Minor complaint if you want to go in and fix it.

Comment thread fission/src/ui/panels/mirabuf/ImportMirabufPanel.tsx Outdated
Co-authored-by: Alexey Dmitriev <157652245+AlexD717@users.noreply.github.com>

@azaleacolburn azaleacolburn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this PR makes more than one change, so I can't approve it. Please use Claude to automatically open new sub-PRs next time /j

Comment thread fission/src/systems/World.ts Outdated
Co-authored-by: Azalea Colburn <62953415+azaleacolburn@users.noreply.github.com>
@rutmanz
rutmanz requested a review from azaleacolburn July 22, 2026 15:26
@PepperLola
PepperLola merged commit 7941319 into dev Jul 22, 2026
17 of 18 checks passed
@PepperLola
PepperLola deleted the zachr/231/vite-hmr branch July 22, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Related to the development process (workflows, dev-facing improvements, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants